[hibernate-dev] [OGM] Configuration parsing

[Guillaume SCHEIBEL]

Hello,


With the time we are implementing more and more configuration properties
(especially for the MongoDB module) which makes the *DatastoreProvider more
and more heavy. And some configuration checks (the port between 1 and 65535
for instance) are done several times instead being centralized at 1 place.

The other problem is because of the "all in the DatastoreProvider"
strategy, some configuration tests can only be done once the start() method
has been called and for a module like MongoDB, the start() method will try
to make a call and so the test takes ~30sec instead of being
almost instantaneous.

My question is what do you think about pulling out the configuration part
of the datastoreprovider (which will basically only  be responsible of the
start() and stop()).
And put it into a configurationParser called from
OgmJdbcServicesInitiator.configure(). And the configuration will be
represented as an object (somehow like in ISPN) and this object will be
used by the datastoreprovider to retrieve the properties.

I think it can help to improve both config readability and the test time.
Any thoughts ?

Guillaume