[hibernate-dev] Checkstyle breaking the OGM build

[Emmanuel Bernard]

I found the problem, not sure where that comes from though.

On a fresh repo clone it works as expected. So I did diff the two and
found that the failing version has lines ending as CRLF (Windows) and
the fresh repo has lines ending as LF (Unix).

On Fri 2013-05-03  8:32, Gunnar Morling wrote:
> Works for me on my Mac as expected, i.e. I get the violation only when I
> really add another new line.
> 
> > I'm wondering if we really want to keep this rule
> 
> Personally I like the rule, several empty lines always look a bit odd to
> me. But if the check can't be executed reliably, it's surely not big loss.
> 
> --Gunnar
> 
> 
> 
> 2013/5/3 Sanne Grinovero <sanne at hibernate.org>
> 
> > Can't reproduce this either. I'm wondering if we really want to keep this
> > rule: its benefit is limited and even before this case we had trouble with
> > it on windows.
> > On 2 May 2013 23:41, "Guillaume SCHEIBEL" <guillaume.scheibel at gmail.com>
> > wrote:
> >
> > > Hi Emmanuel,
> > >
> > > Sorry I can't reproduce it and both maven & intellij plugins are telling
> > me
> > > the Label class respects the rules.
> > >
> > > Guillaume
> > >
> > >
> > > 2013/5/3 Emmanuel Bernard <emmanuel at hibernate.org>
> > >
> > > > Taking OGM master, I get a checkstyle failure on one of the test file.
> > > > But what is surprising is that I don't see new lines at the end of the
> > > > described file.
> > > >
> > > > Can you guys reproduce?
> > > >
> > > > Emmanuel
> > > >
> > > > [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
> > > > hibernate-ogm-core ---
> > > > [debug] execute contextualize
> > > > [INFO] Using 'UTF-8' encoding to copy filtered resources.
> > > > [INFO] Copying 2 resources
> > > > [INFO]
> > > > [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @
> > > > hibernate-ogm-core ---
> > > > [INFO] Compiling 150 source files to
> > > > /Users/emmanuel/Code/ogm/hibernate-ogm-core/target/classes
> > > > [INFO]
> > > > [INFO] --- maven-checkstyle-plugin:2.10:checkstyle (check-style) @
> > > > hibernate-ogm-core ---
> > > > [INFO] Starting audit...
> > > >
> > > >
> > >
> > /Users/emmanuel/Code/ogm/hibernate-ogm-core/src/test/java/org/hibernate/ogm/test/id/Label.java:64:
> > > > Only one new line is allowed at the end of a file
> > > > Audit done.
> > > >
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [INFO] Reactor Summary:
> > > > [INFO]
> > > > [INFO] Hibernate OGM Aggregator .......................... SUCCESS
> > > > [3.493s]
> > > > [INFO] Hibernate Object Grid Mapper ...................... FAILURE
> > > > [28.596s]
> > > > [INFO] Hibernate OGM Ehcache integration ................. SKIPPED
> > > > [INFO] Hibernate OGM Infinispan integration .............. SKIPPED
> > > > [INFO] Hibernate OGM Module .............................. SKIPPED
> > > > [INFO] Hibernate OGM Integration and performance Tests ... SKIPPED
> > > > [INFO] Hibernate OGM Integration Test case ............... SKIPPED
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [INFO] BUILD FAILURE
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [INFO] Total time: 33.217s
> > > > [INFO] Finished at: Fri May 03 00:14:08 CEST 2013
> > > > [INFO] Final Memory: 36M/335M
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-checkstyle-plugin:2.10:checkstyle
> > > > (check-style) on project hibernate-ogm-core: An error has occurred in
> > > > Checkstyle report generation. Failed during checkstyle execution: There
> > > > are 1 checkstyle errors. -> [Help 1]
> > > > [ERROR]
> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > the
> > > > -e switch.
> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > > > [ERROR]
> > > > [ERROR] For more information about the errors and possible solutions,
> > > > please read the following articles:
> > > > [ERROR] [Help 1]
> > > >
> > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> > > > [ERROR]
> > > > [ERROR] After correcting the problems, you can resume the build with
> > the
> > > > command
> > > > [ERROR]   mvn <goals> -rf :hibernate-ogm-core
> > > > _______________________________________________
> > > > hibernate-dev mailing list
> > > > hibernate-dev at lists.jboss.org
> > > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > > >
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >