[hibernate-dev] Need some help for new property types

[Ajay Bhat]

Thanks so much, Davide! Could you and/or the community review the below
pull request?

https://github.com/hibernate/hibernate-ogm/pull/461

On Mon Dec 22 2014 at 5:42:14 PM Davide D'Alto <davide at hibernate.org> wrote:

> Hi,
> I gave a quick look at the patch, I think the reason it is not working
> with MongoDB is that MongoDB does not support natively Character type.
>
> You need to use a different CharacterType implementation for MongoDB, you
> can do it via the method MongoDBDialect.overrideType(...). You will find
> that we are already doing it for other types like Byte and Calendar for
> example.
> You should do the same for Character (and Short I suspect).
>
> I have also created a branch where I rebased your  work to the latest
> changes and fixed the checktyle errors (branch 401 on my repository):
> https://github.com/DavideD/hibernate-ogm/tree/OGM-401
>
> I hope this help,
> Davide
>
> On Mon, Dec 22, 2014 at 10:43 AM, Davide D'Alto <davide at hibernate.org>
> wrote:
>>
>> Hi Ajay,
>> sorry we were quiet in these days, we worked hard for the latest OGM
>> release and most of us have started the Christmas holidays.
>>
>> I'm packing for my holidays as well so I don't think I will be able to
>> look at this now.
>> I'll try to have a look at it tomorrow.
>>
>> Cheers,
>> Davide
>>
>>
>> On Mon, Dec 22, 2014 at 2:06 AM, Ajay Bhat <a.ajay.bhat at gmail.com> wrote:
>>>
>>> Hi,
>>> I was working on OGM-401 (Implementing new property types) and I
>>> encountered some errors while running the tests. I'd asked about it in
>>> the
>>> IRC, but since there wasn't anyone there at the time, I thought I'd ask
>>> around here.
>>>
>>>
>>> http://transcripts.jboss.org/channel/irc.freenode.org/%23hibernate-dev/2014/%23hibernate-dev.2014-12-21.log.html
>>>
>>> Thanks,
>>> Ajay
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>