[hibernate-dev] [OGM-441] Pull request workflow in JIRA

Sanne Grinovero sanne at hibernate.org
Thu Jul 17 12:15:24 EDT 2014


On 17 July 2014 16:53, Gunnar Morling <gunnar at hibernate.org> wrote:
> I've no strong opinion, both ways work for me.
>
> At least I haven't missed the feature so far, and as Sanne is saying, pull
> requests are referenced automatically now anyways. Is there any strong
> advantage of using that workflow?

No it's not going to solve the world's problems.

I listed why I like it, and how I minimize the hassle. And as a I
said, PRs are not consistently tracked.

But the benefits of traceability which I listed are used only
occasionally, and the "status overview" is used only by a a few of us
and I could use labels or just a status without link to achieve
similar benefits.

The question is if the small burden paid by everyone are a reasonable
cost for the benefits of the few.

I have no strong opinion either.

>
>
> Am 17.07.2014 15:18 schrieb "Sanne Grinovero" <sanne at hibernate.org>:
>
>
>>
>> On 17 July 2014 13:59, Emmanuel Bernard <emmanuel at hibernate.org> wrote:
>> > Hibernate Search has a pull request workflow where a specific status
>> > Pull Request Sent exists.
>> > Do we want it for OGM? Do you think it would add more value to the
>> > clutter it brings?
>> >
>> > That question is mostly for Gunnar and Davide. I am neutral personally.
>> >
>> > Sanne what’s your feedback after using it in HSearch?
>>
>> Personally I like it as it's good to be able to track the current
>> state of release progress; I use filters to plan releases and that
>> gives a quick visibility sorting by issue status.
>>
>> The link is useful but not essential; apparently JIRA is now supposed
>> to automatically create the links but it seems not perfect yet, I'm
>> not understanding why it sometimes auto-links and sometimes there's
>> nothing. Ideally if that improves I'd be happy with a status change,
>> *especially* as all of this can eventually be scripted in a REST based
>> script to send PRs and all status updates in one go (both github and
>> JIRA have nice REST APIs).
>>
>> Also JIRA tends to flag the PR as "rejected" when you merge & close it
>> after rebasing. I guess that's not going to be fixed easily so we need
>> to help it somehow.
>>
>> Sanne
>>
>> >
>> > Emmanuel
>> > _______________________________________________
>> > hibernate-dev mailing list
>> > hibernate-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev



More information about the hibernate-dev mailing list