[hibernate-dev] [OGM] types and sequence generator in dialect package

[Gunnar Morling]

Atm. it's not handled consistently between dialects; e.g.
hibernate-ogm-mongodb already has a "type" package as you suggest.

+1 for making it consistent and having separate packages as you propose.

--Gunnar



2014-05-14 16:12 GMT+02:00 Emmanuel Bernard <emmanuel at hibernate.org>:

> adding the mailing list back.
>
> Other datastores use the same approach as you so we need to eb
> consistent
>
> On Wed 2014-05-14 11:22, Davide D'Alto wrote:
> > Neo4jSequenceGenerator and Neo4jTypeConverter were the result of some
> code
> > that I've extracted from the dialect.
> > Initially I didn't expect them to be used somewhere else outside the
> > dialect.
> >
> > Sounds good to me to move them to a separate package.
> >
> >
> > On Wed, May 14, 2014 at 8:08 AM, Emmanuel Bernard <
> emmanuel at hibernate.org>wrote:
> >
> > > It does not make a huge difference as these are in impl packages but I
> > > wonder if somebody has a specific reasoning for putting types
> > > (converters) and sequence generators inside the dialect package?
> > >
> > > Granted they are wired in the dialect but in practice they are used by
> > > the code base at large. I think naturally I would ahve put them under
> > >
> > >     o.h.o.datastore.somenosql.type / generator or idgenerator
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>