[hibernate-dev] Closed pull requests

Steve Ebersole steve at hibernate.org
Thu Oct 30 18:43:53 EDT 2014


Well telling me/us which PRs got closed would be a good first step :)

Overall, checking that the PR still applies is a good idea too.

On Thu, Oct 30, 2014 at 5:34 PM, Andrej Golovnin <golovnin at gmx.net> wrote:

>
> > On 30.10.2014, at 23:15, Steve Ebersole <steve at hibernate.org> wrote:
> >
> > Well maybe rather than being hurt and sensitive maybe just understand
> that it was not intentional.  GitHub automatically closed them.  It was
> simply a mistake.
> >
> > Or be sensitive and threatening about it.  Whichever you think helps you
> best ;)
>
> This does not answer my 1. question. :-) What is the best way to proceed?
> Are you going to reopen the pull requests or should we create new requests?
>
> I think, that at least one of my patches must be modified to be applied to
> the "new master".
>
> Any clear small guide, what we (contributors) should do to reopen the pull
> requests
> or a small info that you will care about the closed pull requests
> and we should sit down, relax and wait until you are done, would be really
> helpful.
>
> >
> > On Oct 30, 2014 11:05 PM, "Andrej Golovnin" <golovnin at gmx.net> wrote:
> > Hello Steve,
> >
> > you have closed my pull requests and
> > pull requests from others too without any comment.
> >
> > Should we create a new pull requests for the "new master" branch?
> > Or should we just forget all the time and the work we have invested
> > to create those pull requests and stop submitting any new pull requests
> > in the future?
> >
> > Best regards,
> > Andrej Golovnin
>
>


More information about the hibernate-dev mailing list