[hibernate-dev] hibernate-core and hibernate-infinspan failures

[John O'Hara]

Yes, you can see the difference between the call to createEntityEntry 
for the Mutable and Immutable case here: 
https://github.com/hibernate/hibernate-orm/blob/7633d2fce540a979fc0eb5b229023c815b6c5528/hibernate-core/src/main/java/org/hibernate/engine/internal/StatefulPersistenceContext.java#L505

In the tests where lazyPropertiesAreUnfetched is set to true, the 
disableVersionIncrement was inadvertently being set to true for 
MutableEntitEntry's and therefore the version was not being incremented. 
That was causing the tests to fail as the Entity version was not 
incremented during the tests

On 18/11/15 14:34, Steve Ebersole wrote:
> So if I understand correctly, I just inverted the 2 booleans arguments when
> trying to apply this to 5.0?
>
>
> On Wed, Nov 18, 2015 at 4:27 AM John O'Hara <johara at redhat.com> wrote:
>
>> Gail,
>>
>> Tests on hibernate-core in 5.0 branch are failing due to
>>
>> https://github.com/hibernate/hibernate-orm/commit/7633d2fce540a979fc0eb5b229023c815b6c5528
>> lazyPropertiesAreUnfetched should be passed after
>> disableVersionIncrement.  I will make the change for steve to pull in
>>
>> John
>>
>> On 18/11/15 06:32, Gail Badner wrote:
>>> I noticed that there are 39 test failures for hibernate-core in 5.0
>> branch.
>>> [1]
>>>
>>> Also, I enabled hibernate-infinispan tests on 5.0 and there are 8
>> failures.
>>> [2] Some of the failures are due to IllegalLifecycleStateException, which
>>> doesn't look like the intermittent failures I've seen in the past.
>>>
>>> I suppose the hibernate-infinispan tests could be failing for the same
>>> reason the hibernate-core tests are failing. I figured I'm mention it in
>>> case they are unrelated.
>>>
>>> [1] http://ci.hibernate.org/job/hibernate-orm-5.0-h2/11/testReport/
>>> [2] http://pastebin.com/LHppW5jm
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>> --
>> John O'Hara
>> johara at redhat.com
>>
>> JBoss, by Red Hat
>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
>> Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
>> Registered in UK and Wales under Company Registration No. 3798903
>> Directors: Michael Cunningham (USA), Charlie Peters (USA), Matt Parsons
>> (USA) and Michael O'Neill (Ireland).
>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev


-- 
John O'Hara
johara at redhat.com

JBoss, by Red Hat
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
Registered in UK and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Charlie Peters (USA), Matt Parsons (USA) and Michael O'Neill (Ireland).