[hibernate-dev] Importing OGM in Eclipse: workaround needed [AKA: the domino effect of fixing your own tools..]

[Sanne Grinovero]

On 10 August 2016 at 09:42, Gunnar Morling <gunnar at hibernate.org> wrote:
> Hi,
>
> Could you just add a note on the required plug-in version to the readme
> and/or contribution guide.

Ok, adding to readme however let's hope it won't have to stay there for long:
 - https://github.com/hibernate/hibernate-ogm/pull/747

Since you felt this needed some addressing, wouldn't you rather apply
my workaround to the project?
At least occasional contributors wouldn't have to face this step.

I'll polish my "workaround" with some more comments and send that as PR too.

>
> Thanks,
>
> --Gunnar
>
>
> 2016-08-10 10:15 GMT+02:00 Sanne Grinovero <sanne at hibernate.org>:
>>
>> On 10 August 2016 at 07:12, Guillaume Smet <guillaume.smet at gmail.com>
>> wrote:
>> > Hi Sanne,
>> >
>> > First, sorry for not mentioning it as I run into this problem a few
>> > weeks ago. I must admit that, as noone complained about it, I thought
>> > I was the only one with the problem and it was already fixed in recent
>> > Neon releases.
>>
>> I was very puzzled that this problem was "only on my machine".
>>
>> > The fact is that using maven-jar-plugin 3.0.0 is not an option as it
>> > has memory issues. Yoann got them at OW and we had a few Travis build
>> > failures on OGM because of that when I first upgraded to 3.0.0.
>>
>> You mentioned that, and I assume this was
>> https://issues.apache.org/jira/browse/MJAR-226 ?
>> That's why my workaround overrides the version of maven-archiver :
>> essentially it cherry picks the memory bugfix w/o the other changes.
>>
>> >
>> > If we want to patch OGM, we have to go back to maven-jar-plugin 2.6
>> > instead of 3.
>> >
>> > Maybe we could ask Fred if an update is planned soon and decide with
>> > that in mind?
>>
>> yes, I'll put this aside for now as my local m2e works fine with
>> Fred's update... if there's need, all references are on this mailing
>> list.
>>
>> Thanks,
>> Sanne
>>
>> >
>> > --
>> > Guillaume
>> >
>> > On Tue, Aug 9, 2016 at 11:51 PM, Sanne Grinovero <sanne at hibernate.org>
>> > wrote:
>> >> Hi all,
>> >> I was having critical issues with Eclipse / OGM after a recent rebase,
>> >> which seemed was caused by:
>> >>  - https://hibernate.atlassian.net/browse/OGM-1102
>> >>
>> >> The new maven-jar-plugin is no longer compatible with latest m2e
>> >> integration, Fred Bricon already published an m2e preview with a fix;
>> >> if you have this problem use this updated site to update m2e:
>> >>  -
>> >> https://otto.takari.io/content/sites/m2e.extras/m2eclipse-mavenarchiver/0.17.2/N/LATEST/
>> >>
>> >> But there's a punch line.. the compatibility was broken because
>> >> plex-tools, a dependency of maven-jar-plugin, was upgraded .. who
>> >> would ever do such a thing!!! what an idiot :D :
>> >>  - https://issues.apache.org/jira/browse/MJAR-205
>> >>
>> >> As an alternative to update m2e could apply this patch:
>> >>  -
>> >> https://github.com/hibernate/hibernate-ogm/commit/36b37f76215e52b235ed362e6be0f7d40a4a12e9
>> >>
>> >> I'm tempted to throw my patch away and stick to the m2e preview.. let
>> >> me know if you all prefer me to apply the workaround on OGM.. the
>> >> benefit would be that Eclipse Neon would be able to import OGM out of
>> >> the box, however I expect m2e will automatically update soon enough.
>> >>
>> >> At least I had an honest LOL..
>> >>
>> >> Cheers,
>> >> Sanne
>> >> _______________________________________________
>> >> hibernate-dev mailing list
>> >> hibernate-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
>