[hibernate-dev] [Search] Range faceting for Longs and Dates not taking into account hasZeroCountsIncluded

[Hardy Ferentschik]

Hi,

On Wed, Feb 03, 2016 at 09:15:31AM +0100, Emmanuel Bernard wrote:
> It's probably a bug, Hardy, you confirm?

Sounds like an oversight. I would add it, make sure tests still pass and
add some new ones ;-)

--Hardy


> 
> On Tue 2016-02-02 15:40, Guillaume Smet wrote:
> > Hi,
> > 
> > While playing with ElasticSearch faceting (and having tests failing due to
> > that), I noticed that for Longs and Dates, the preexisting range faceting
> > doesn't take into account facetRequest.hasZeroCountsIncluded().
> > 
> > See
> > https://github.com/hibernate/hibernate-search/blob/master/engine/src/main/java/org/hibernate/search/query/engine/impl/QueryHits.java#L308
> > and a few lines below for floating point ranges which take into account
> > this very parameter.
> > 
> > Is this something expected? Should I prepare a PR to fix it?
> > 
> > -- 
> > Guillaume
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 496 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/hibernate-dev/attachments/20160203/a9409b8e/attachment.bin