[hibernate-dev] Revert API change in org.hibernate.Query

[Sanne Grinovero]

On 7 June 2016 at 13:41, Steve Ebersole <steve at hibernate.org> wrote:
> If you send a PR I will include it.

Thanks Steve, I finally got to it:
 - https://hibernate.atlassian.net/browse/HHH-10839
 - https://github.com/hibernate/hibernate-orm/pull/1418



>
> On Sun, Jun 5, 2016 at 11:00 AM Sanne Grinovero <sanne at hibernate.org> wrote:
>>
>> I just noticed that the org.hibernate.Query interface was deprecated
>> in 5.2, with the suggestion to use org.hibernate.query.Query now.
>> That's ok, but it seems the "deprecation process" also forced some API
>> changes already on the deprecated interface which seem might have been
>> unintentional.
>>
>> The builder methods on org.hibernate.Query used to allow returning
>> "this" to chain methods,
>> although this seems no longer possible as the API now declares the
>> return type should be the new one, org.hibernate.query.Query.
>>
>> Could we fix this by relaxing the return to the older deprecated method?
>>
>> in practice:
>>
>>  org.hibernate.query.Query<R> setFirstResult(int startPosition);
>>
>> should be:
>>
>>  org.hibernate.Query<R> setFirstResult(int startPosition);
>>
>> Thanks,
>> Sanne
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev