[hibernate-dev] Module ZIP for upgrading Hibernate ORM in WildFly

[Gunnar Morling]

Hey,

I've sent PR https://github.com/hibernate/hibernate-orm/pull/1455 earlier
today for this.

> What happens if we copy the contents of the org.hibernate.jipijapa-hibernate5
module, to org.hibernate.jipijapa-hibernate5-1.
> Change org.hibernate.jipijapa-hibernate5-1, to depend on ORM 5.1 and
change ORM 5.1 to depend on org.hibernate.jipijapa-hibernate5-1.

Yes, that's what I ended up doing. At first I wasn't aware of that circular
dependency between the two modules, thus missing to update one of the
references to the 5.1 slot and hence pulling in the WF-provided ORM.

> I'm guessing but most likely by copying the above module reference to
"org.hibernate.jipijapa-hibernate5" into the ORM 5.1 module.xml.

Exactly.

Alternatively, I just could add the JipiJapa adapter JAR to my ORM 5.1
module, itself. But I decided to stick to the original WF structure as
close as possible.

That dependency to org.hibernate:main from org.jboss.as.ejb3 still looks a
bit scary. My simple test passes, not sure whether that may be a problem in
other cases, though?

--Gunnar




2016-06-27 15:39 GMT+02:00 Scott Marlow <smarlow at redhat.com>:

>
>
> On 06/25/2016 05:12 PM, Sanne Grinovero wrote:
> > On 25 June 2016 at 13:15, Gunnar Morling <gunnar at hibernate.org> wrote:
> >> Ok, so this was caused by the module dependency
> >> from org.hibernate.jipijapa-hibernate5 to org.hibernate. Seems I need to
> >> create a 5.1-specific adapter module, too, and require that to be
> >> configured by users via jboss.as.jpa.adapterModule.
>
> What happens if we copy the contents of the
> org.hibernate.jipijapa-hibernate5 module, to
> org.hibernate.jipijapa-hibernate5-1.  Change
> org.hibernate.jipijapa-hibernate5-1, to depend on ORM 5.1 and change ORM
> 5.1 to depend on org.hibernate.jipijapa-hibernate5-1.
>
> >
> > If you include the adaptor module with the ORM modules, it should be
> > auto-discovered.
>
> The ORM 5.0 module.xml has the following so that service loading can do
> the discovery:
>
> "
> <module name="org.hibernate.jipijapa-hibernate5" services="import"/>
> "
>
> >
> > See how OGM does it.
> >
> > I'm not sure I understood why you were being exposed to the
> > jipijapa-hibernate5 module though?
>
> I'm guessing but most likely by copying the above module reference to
> "org.hibernate.jipijapa-hibernate5" into the ORM 5.1 module.xml.
>
> > This shouldn't activate automatically when you change the
> > providerModule setting.
> >
> > --Sanne
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>