[hibernate-dev] ArrayHelper cleanup

[Vlad Mihalcea]

Good thing that you mentioned it. I'd have go through all Hibernate
projects to make sure that I don't miss any method usage case.

On Mon, Mar 21, 2016 at 4:54 PM, Emmanuel Bernard <emmanuel at hibernate.org>
wrote:

> On Mon 2016-03-21 13:38, Vlad Mihalcea wrote:
> > Hi,
> >
> > When reviewing this PR (
> > https://github.com/hibernate/hibernate-orm/pull/1305/files), I noticed
> that
> > some methods can be simply replaced by java.util.Arrays (e.g. indexOf,
> > toStringArray),
> > while other methods are not used at all (e.g. reverse).
> >
> > Since this is an internal helper utility, do we want to clean it by
> > removing the unused/commented/redundant methods, or shall we leave it as
> is?
>
> Make sure OGM and Search still work when you remove such methods.
> We try and be clean and not depend on super private classes but we might
> have slipped here and there.
>