[hibernate-dev] Checkstyle checks in ORM
Steve Ebersole
steve at hibernate.org
Wed Nov 9 10:42:00 EST 2016
https://hibernate.atlassian.net/browse/HHH-11235
On Wed, Nov 9, 2016 at 9:22 AM Steve Ebersole <steve at hibernate.org> wrote:
> Gradle does not have profiles. So you mean different tasks?
>
>
> On Wed, Nov 9, 2016 at 9:20 AM Vlad Mihalcea <mihalcea.vlad at gmail.com>
> wrote:
>
> I like Davide's proposal. +1
>
> On Wed, Nov 9, 2016 at 5:14 PM, Davide D'Alto <davide at hibernate.org>
> wrote:
>
> What do you think about having different profiles?
> One for new contributors (more relaxed)
> and one for active developers.
>
> Given that I'm not sure what kind of checkstyle rules we are talking about.
>
> On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve at hibernate.org>
> wrote:
> > While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is
> a
> > valid problem in the ORM build. Namely the fact that we incorporate
> > non-fatal Checktyle checks. In local builds this leads to a situation
> > where it is extremely difficult for new contributors to find out what
> > exactly they violated. Jenkins presents these better and makes it easier
> > to see just "fatal" (high priority) violations, but the Checktype report
> > itself does not. Even worse the Checkstyle report does not even show the
> > priority of individual violations at all.
> >
> > I suggest we remove all non-fatal Checkstyle rules to make it easier on
> > contributors.
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
>
>
More information about the hibernate-dev
mailing list