[hibernate-dev] DB2 cross joins

[Sanne Grinovero]

On 16 February 2017 at 14:23, Chris Cranford <crancran at gmail.com> wrote:
> We have actually discussed doing something where Dialect's auto-configure
> themselves, but such a change would likely be appropriate for a major
> release only.
>
> On 02/16/2017 04:57 AM, Christian Beikov wrote:
>> How about a different approach? Like passing the DB version somehow to
>> the dialect so that it can decide for itself instead of having different
>> subclasses.

People currently expect to be able to configure a Dialect by choosing
a specific classname.

I don't disagree on exploring evolutions, but indeed I'd not change
such matters in a minor release;

Gail needs a fix focusing on the cross join issue so a new class will
suffice for the immediate need.

>>
>> Am 16.02.2017 um 08:16 schrieb Gail Badner:
>>> HHH-11487 can be fixed by using changing DB2Dialect#getCrossJoinSeparator
>>> to return " cross join ".
>>>
>>> DB2 9.1 did not support CROSS JOIN, but DB2 9.5 and later do support CROSS
>>> JOIN. I see that DB2 9.1 is no longer supported as of April 30, 2015.
>>>
>>> It's tempting to just update DB2Dialect, but I suspect that would break
>>> existing applications still using DB2 9.1.
>>>
>>> I'm considering adding a new dialect DB295Dialect that extends DB2Dialect
>>> and overrides DB2Dialect#getCrossJoinSeparator to return "cross join".
>>>
>>> WDYT?

+1

Thanks,
Sanne


>>>
>>> Regards,
>>> Gail
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev