[hibernate-dev] Pull request

Vlad Mihalcea mihalcea.vlad at gmail.com
Wed Jun 7 12:38:10 EDT 2017


There are 100, but that's because some of them are for 4.x or 5.0, 5.1 or
they lack Tets Cases or the user hasn't confirmed the CLA.
We integrate most Pull Requests in a timely fashion.

Vlad

On Wed, Jun 7, 2017 at 6:08 PM, Sanne Grinovero <sanne at hibernate.org> wrote:

> On 7 June 2017 at 15:46, Vlad Mihalcea <mihalcea.vlad at gmail.com> wrote:
> > Hi Sanne,
> >
> > The PR queue has not been neglected at all. The problem was that the
> issue
> > was still marked with the "Requires Changes" label, and I assumed it was
> not
> > done yet.
>
> Great to hear. Sorry, I just assumed it was the case as you've all
> been very busy and there are 100+ of them..
>
> Thanks,
> Sanne
>
> >
> > Vlad
> >
> > On Wed, Jun 7, 2017 at 12:41 PM, Sanne Grinovero <sanne at hibernate.org>
> > wrote:
> >>
> >> Hi Milo,
> >>
> >> apologies for that. The ORM team had some meetings, travelling, etc..
> >> I guess the PR queue has been temporarily neglected and they'll have
> >> to catch up.
> >>
> >> I don't think you missed something, good idea to call for attention on
> >> the mailing list.
> >>
> >> Thanks,
> >> Sanne
> >>
> >>
> >> On 6 June 2017 at 20:36, Milo van der Zee <milo at vanderzee.org> wrote:
> >> > Hello,
> >> >
> >> > I submitted a pull request and fixed some issues with it (jUnit test
> and
> >> > formatting) and after that nothing happens. How does this work? Do I
> >> > just have to be patient or do I miss something?
> >> >
> >> > https://github.com/hibernate/hibernate-orm/pull/1906
> >> >
> >> > MAG,
> >> > Milo
> >> >
> >> > _______________________________________________
> >> > hibernate-dev mailing list
> >> > hibernate-dev at lists.jboss.org
> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >> _______________________________________________
> >> hibernate-dev mailing list
> >> hibernate-dev at lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> >
>


More information about the hibernate-dev mailing list