[hibernate-dev] HHH-10162 Inheritance and L2 cache

[Gail Badner]

Hi Christian,

I've added some comments to the PR.

As I mentioned there, this appears to be a partial fix. If the application
really requires the entity to implement the "correct" class, then this will
still break for them when the entity is not in the cache.

I'm not sure if a partial fix really suffices. IIUC, enhancement would work.

What to others think about this?

Regards,
Gail

On Thu, Mar 2, 2017 at 11:59 AM, Christian Beikov <
christian.beikov at gmail.com> wrote:

> I can, just wanted to hear some general opinions before creating the PR.
> Will do that tomorrow.
>
>
> Mit freundlichen Grüßen,
> ------------------------------------------------------------------------
> *Christian Beikov*
> Am 02.03.2017 um 20:57 schrieb Gail Badner:
> > Hi Christian,
> >
> > You mentioned that you reproduced the issue, but I don't see a test
> > case. Can you push your test case to a PR?
> >
> > Thanks,
> > Gail
> >
> > On Thu, Mar 2, 2017 at 10:15 AM, Steve Ebersole <steve at hibernate.org
> > <mailto:steve at hibernate.org>> wrote:
> >
> >     BTW, regarding the Hip Chat "Dev" room, I'd personally not rely on
> >     replies
> >     from there.  E.g. I never saw your question there, and others
> >     likely did
> >     not either.  FWIW we had all agreed on a block of time when we
> >     would try to
> >     be available in that room specifically to discuss such things.
> >     IIRC that
> >     was roughly between 10 and 12 my time (central US).
> >
> >     On Thu, Mar 2, 2017 at 12:08 PM Christian Beikov
> >     <christian.beikov at gmail.com <mailto:christian.beikov at gmail.com>>
> >     wrote:
> >
> >     > Hey guys,
> >     >
> >     > Steve said I should start a discussion about the possible
> >     solution for
> >     > HHH-10162 <https://hibernate.atlassian.net/browse/HHH-10162
> >     <https://hibernate.atlassian.net/browse/HHH-10162>> so here we
> >     > go.
> >     >
> >     > While debugging the issue, I found out that the proxy is created at
> >     > DefaultLoadEventListener.createProxyIfNecessary() where it IMO
> >     should
> >     > consult the 2L cache first by calling existing =
> >     > loadFromSecondLevelCache( event, persister, keyToLoad );. The
> >     fix looks
> >     > easy, but I am not sure of the implications. Obviously this will
> >     affect
> >     > performance a little since it has to consult the L2 cache now.
> >     >
> >     > I tried to start a discussion in the Dev room, but so far only
> >     Andrea,
> >     > Vlad and Chris have commented this. Has anyone a different idea for
> >     > implementing this?
> >     > --
> >     >
> >     > Mit freundlichen Grüßen,
> >     >
> >     ------------------------------------------------------------
> ------------
> >     > *Christian Beikov*
> >     > _______________________________________________
> >     > hibernate-dev mailing list
> >     > hibernate-dev at lists.jboss.org <mailto:hibernate-dev at lists.
> jboss.org>
> >     > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >     <https://lists.jboss.org/mailman/listinfo/hibernate-dev>
> >     _______________________________________________
> >     hibernate-dev mailing list
> >     hibernate-dev at lists.jboss.org <mailto:hibernate-dev at lists.jboss.org>
> >     https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >     <https://lists.jboss.org/mailman/listinfo/hibernate-dev>
> >
> >
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>