[hibernate-dev] org.hibernate.event.spi Listener changes for 6 ?

[Gunnar Morling]

2017-05-17 2:01 GMT+02:00 Steve Ebersole <steve at hibernate.org>:
> On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero <sanne at hibernate.org>
> wrote:
>
>> Since 6 is coming I'd like to suggest two trivial changes for the
>> listeners:
>>
>> # Serializable
>>
>> I assume we can drop the "extend Serializable" from all these interfaces ?
>>
>>
> Personally I've never been a fan of interfaces extending Serializable, so I
> am fine with that.

That's great. I always was confused by the requirement for
serialisability for listeners, services etc. So if that actually can
be removed, that's very nice.

>
>
>
>> # PostInsertEventListener.requiresPostCommitHanding(EntityPersister)
>>
>> I suspect there is a typo in this method?
>> N.B. there are some more copies of `requiresPostCommitHanding` in
>> other listeners, beyond the PostInsertEventListener.
>
>
> Fine by me, but I wonder if we ought to deprecate it instead and use
> default methods.  Or maybe do that retro in 5.2 and do clean in 6
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev