[hibernate-dev] How is LogicalConnectionImplementor#makeShareableCopy intended to be used?

[Steve Ebersole]

It was originally intended for "shared Session" handling, but we ended up
handling this differently.  I believe this can go away.

On Tue, Sep 12, 2017 at 2:42 PM Gail Badner <gbadner at redhat.com> wrote:

> LogicalConnectionImplementor#makeShareableCopy [1] doesn't seem to be used
> by anything.
>
> The implemented method in LogicalConnectionManagedImpl returns null. [2]
>
> Should this method be deprecated?
>
> I'm asking because I created a PR [3] that allows passing JdbcObserver
> to ResourceRegistryStandardImpl so that any existing batch can be cleaned
> up before releasing JDBC resources.
>
> In my PR, the LogicalConnectionProvidedImpl#makeShareableCopy results in a
> LogicalConnectionProvidedImpl with a ResourceRegistryStandardImpl that has
> a null JdbcObserver.
>
> It didn't make sense to me that the original and shareable
> ResourceRegistryStandardImpl should both have the same JdbcObserver, but
> I'm really not sure about this.
>
> If LogicalConnectionImplementor#makeShareableCopy really is not used and
> should be deprecated, I won't worry about this.
>
> I'd like to get my PR merged for 5.2.11 tomorrow, so a quick response would
> be greatly appreciated. If I don't hear back, I'll push it to 5.2.12.
>
> Thanks,
> Gail
>
> [1]
>
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/resource/jdbc/spi/LogicalConnectionImplementor.java#L61-L66
> [2]
>
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/resource/jdbc/internal/LogicalConnectionManagedImpl.java#L217-L223
> [3] https://github.com/hibernate/hibernate-orm/pull/2004
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>