[hibernate-dev] Possible regression due to the new entity graph code

[Steve Ebersole]

Commented on the Jira.  It is a regression, though it is not caused
specifically by the graph changes.  It is caused more by a change in how
subsequent selects are fired.  If it was an intentional change, it would be
good to understand why it was changed so we can make an informed decision
about how to best resolve this - whether the subsequent-select changes
ought to reverted or if we should adjust the graph handling to account for
that change.  My concern is that the subsequent-select changes might lead
to other such hard-to-diagnose problems.

FWIW, changing graph handling wrt `#find` *should be* trivial.  I'll work
on a PR using this approach to verify it is indeed trivial (after I'm
actually back from vacation).

P.S.  Note that this only affects `#find` operations.  Graphs applied to
HQL or criteria queries do not have this issue.  So that is a viable
workaround.


On Thu, Dec 27, 2018 at 6:49 AM Guillaume Smet <guillaume.smet at gmail.com>
wrote:

> Hi,
>
> Looks like we have a regression due to the new entity graph code in 5.4.
>
> * https://hibernate.atlassian.net/browse/HHH-13175 for the test case and
> explanation;
> * https://github.com/hibernate/hibernate-orm/pull/2709 for a fix proposal
> but I don't think we really want to go that way.
>
> Steve, could you take a look at it? I'm pretty sure it's also in 6 as you
> backported things from 6 to 5.4 for this feature.
>
> I plan to release a 5.4.1 probably mid-January to hopefully fix this one
> and the other regressions spotted by our users.
>
> Thanks.
>
> --
> Guillaume
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>