[hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

[Steve Ebersole]

Definitely.  Thanks for doing this


On Thu, Mar 22, 2018, 3:25 PM Gail Badner <gbadner at redhat.com> wrote:

> I'm happy to see all the progress on this while I've been occupied with
> 5.1.13 and some other urgent issues.
>
> I hope to have time to get caught up on things later today or tomorrow.
>
> On Thu, Mar 22, 2018 at 10:55 AM, Gunnar Morling <gunnar at hibernate.org>
> wrote:
>
> > I've mostly used Japicmp recently http://siom79.github.io/japicmp/).
> Works
> > pretty well, but it lacks a way to distinguish between API and SPI, so
> > you'll likely also see "false positives". In fact I thought it's the one
> > you'd be using, but it doesn't seem so from looking at the report
> attached
> > to that wiki page.
> >
> > 2018-03-22 16:59 GMT+01:00 Sanne Grinovero <sanne at hibernate.org>:
> >
> > > On 22 March 2018 at 15:55, David Lloyd <david.lloyd at redhat.com> wrote:
> > > > This tool is usually pretty good; in fact I think it likely that it's
> > > > the best of its kind.  The false positives are really a fairly recent
> > > > development AFAIK; I don't recall hitting any when I ran it for our
> > > > EJB changes a year or two ago.  It might be a good idea to contribute
> > > > a fix for the problem upstream; it might even be relatively easy to
> > > > do.  Or it could already be fixed.
> > >
> > > Good to know, thanks. I might explore that next week.
> > >
> > > Sanne
> > >
> > > >
> > > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole <
> steve at hibernate.org>
> > > wrote:
> > > >> Not sure.  animal-sniffer is the other one I know, but not sure it
> > > would be
> > > >> better.
> > > >>
> > > >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero <
> sanne at hibernate.org
> > >
> > > >> wrote:
> > > >>>
> > > >>> To make sure all the noise form "false positives" won't get us to
> > miss
> > > >>> something, someone knows an alternative tool which can do better?
> > > >>>
> > > >>> Thanks,
> > > >>> Sanne
> > > >>>
> > > >>>
> > > >>> On 22 March 2018 at 14:22, Steve Ebersole <steve at hibernate.org>
> > wrote:
> > > >>> > Yes there were "lots of differences" but a vast majority of them
> > are
> > > >>> > false-positives, not just those listed in the already massive
> > "false
> > > >>> > positives" section.  I've been going through the non-"false
> > positive"
> > > >>> > section and "resolving" specific items (via strike-through) with
> > > either
> > > >>> > (1)
> > > >>> > link to Jira fixing it or (2) comment as to the reason I believe
> it
> > > is a
> > > >>> > false-positive.
> > > >>> >
> > > >>> > I did not bother striking through the "false positives" section.
> > > >>> >
> > > >>> > At this point there are very few unresolved items in this list.
> > > Those
> > > >>> > items
> > > >>> > require more discussion
> > > >>> >
> > > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero <
> > sanne at hibernate.org
> > > >
> > > >>> > wrote:
> > > >>> >>
> > > >>> >> Thanks Gail, great job!
> > > >>> >> I fixed a trivial one, just a thousand to go ;)
> > > >>> >>
> > > >>> >> On 16 March 2018 at 23:09, Gail Badner <gbadner at redhat.com>
> > wrote:
> > > >>> >> > I've moved the document to
> > > >>> >> >
> > > >>> >> >
> > > >>> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC-
> > > 110zcjRaXLllBsvRKw-pdHrMzRzw
> > > >>> >> > .
> > > >>> >> >
> > > >>> >> > Please let me know if you need an invite to view the document.
> > > >>> >> >
> > > >>> >> > The attachments are still at
> https://developer.jboss.org/wiki/
> > > >>> >> > HibernateORMBinaryCompatibilityBetween51And53.
> > > >>> >> >
> > > >>> >> > Regards,
> > > >>> >> > Gail
> > > >>> >> >
> > > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner <
> > gbadner at redhat.com
> > > >
> > > >>> >> > wrote:
> > > >>> >> >
> > > >>> >> >> Hi,
> > > >>> >> >>
> > > >>> >> >> There were lots of differences in the compatibility report,
> so
> > > as a
> > > >>> >> >> first
> > > >>> >> >> step, I've excluded packages/classes that I considered SPI,
> > > >>> >> >> internal,
> > > >>> >> >> or
> > > >>> >> >> "grey area". This reduced the the differences to a more
> > > manageable
> > > >>> >> >> amount.
> > > >>> >> >>
> > > >>> >> >> You can see a summary of the incompatibilities along with
> > > suggested
> > > >>> >> >> mitigation at [1].
> > > >>> >> >>
> > > >>> >> >> The report is attached to [1], along with a zip with
> > instructions
> > > >>> >> >> for
> > > >>> >> >> running the report.
> > > >>> >> >>
> > > >>> >> >> I believe there are some "false positives" in the report,
> and I
> > > have
> > > >>> >> >> documented them in the section, "False Positives?".
> > > >>> >> >>
> > > >>> >> >> Feel free to comment on the article.
> > > >>> >> >>
> > > >>> >> >> Thanks,
> > > >>> >> >> Gail
> > > >>> >> >>
> > > >>> >> >> [1] https://developer.jboss.org/wiki/
> > > HibernateORMBinaryCompatibilit
> > > >>> >> >> yBetween51And53
> > > >>> >> >>
> > > >>> >> >>
> > > >>> >> > _______________________________________________
> > > >>> >> > hibernate-dev mailing list
> > > >>> >> > hibernate-dev at lists.jboss.org
> > > >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > > >>> >> _______________________________________________
> > > >>> >> hibernate-dev mailing list
> > > >>> >> hibernate-dev at lists.jboss.org
> > > >>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > > >
> > > >
> > > >
> > > > --
> > > > - DML
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>