From andrea at hibernate.org Thu Apr 4 10:33:50 2019 From: andrea at hibernate.org (andrea boriero) Date: Thu, 4 Apr 2019 15:33:50 +0100 Subject: [hibernate-dev] Hibernate ORM 6.0.0.Alpha2 has been released Message-ID: For details: http://in.relation.to/2019/04/04/hibernate-orm-600-alpha2-out/ From yoann at hibernate.org Fri Apr 5 03:04:35 2019 From: yoann at hibernate.org (Yoann Rodiere) Date: Fri, 5 Apr 2019 09:04:35 +0200 Subject: [hibernate-dev] Hibernate Search 6.0.0.Alpha4 released Message-ID: Hello, We just published Hibernate Search 6.0.0.Alpha4, the fourth release for the still-in-development 6.0 branch. This release mainly adds an "exists" predicate, improves the DSL by allowing to bypass DSL and projection converters or to override analyzers, restores the Elasticsearch AWS integration, and upgrades the Lucene backend to Lucene 8. As an Alpha, this version is an early technology preview. Be sure to read about it on our blog before you try it out: http://in.relation.to/2019/04/05/hibernate-search-6-0-0-Alpha4/ Cheers, Yoann Rodi?re Hibernate NoORM Team yoann at hibernate.org From gbadner at redhat.com Mon Apr 8 22:32:47 2019 From: gbadner at redhat.com (Gail Badner) Date: Mon, 8 Apr 2019 19:32:47 -0700 Subject: [hibernate-dev] Make Gradle plugin available on plugins.gradle.org? (HHH-13354) Message-ID: An issue was opened to make Gradle plugin available on plugins.gradle.org. Should this be done? If so, how? Regards, Gail From guillaume.smet at gmail.com Tue Apr 9 09:50:26 2019 From: guillaume.smet at gmail.com (Guillaume Smet) Date: Tue, 9 Apr 2019 15:50:26 +0200 Subject: [hibernate-dev] NoORM IRC meeting minutes Message-ID: Hi, Here are the minutes of this week's meeting. The bot was not responding so it's plain text FTW: 15:19 < gsmet> #startmeeting 15:19 < gsmet> hmmm 15:20 < gsmet> looks like the bot has a meeting too 15:20 < koentsje> lol 15:20 < gsmet> I'll copy paste things, I suppose 15:20 < fax4ever> \o/ 15:20 < gsmet> #topic Progress Davide 15:20 < DavideD> Hi 15:21 < DavideD> I worked on the delete and persist of an entity using the reactive approach 15:21 < DavideD> I think I finally figure out what's needed 15:21 < gsmet> nice 15:22 < sannegrinovero> DavideD, there's a lot of people eager to see that working ;) 15:22 < DavideD> It's nce because the query is still generated by ORM but executed with the asyncronous driver 15:23 < DavideD> TO be fair there are still some part that are not ayncronous but for simple case scenario shouldn't matter 15:23 < DavideD> I'm working on the find right now 15:23 < DavideD> I would like to finish that one because it's a bit more complicated as it requires to return the entity 15:24 < DavideD> In the other cases I have nothing to return 15:24 < DavideD> I think that's it from me 15:24 < gsmet> #topic Next 2 weeks Davide 15:25 < DavideD> I will work on session.find 15:25 < DavideD> and then if there is time, an updata so that at least there is a working example for the CRUD operations 15:25 < DavideD> I mean on entity updates 15:26 < gsmet> it's based on ORM 6 or 5.x? 15:26 < DavideD> ORM 6 15:26 < gsmet> cool 15:26 < DavideD> I think that's all 15:26 < gsmet> #topic Progress Fabio 15:27 < fax4ever> In the last two weeks... 15:27 < fax4ever> Firstly, I finished the three issues related to override and ignore the analyzers, 15:27 < fax4ever> for the comparison values provided in the queries. 15:27 < fax4ever> The feature has been released within the 6.0.0.Alpha4. 15:27 < fax4ever> Secondly, I fixed some mismatch between Lucene and Elasticsearch behavior. 15:27 < fax4ever> In particular, on how which they handle the `minimumShouldMatch` parameter. 15:28 < fax4ever> In agreement with Yoann, I forced the Elasticsearch backend to behave as Lucene one. 15:28 < fax4ever> Thirdly, I fixed a wrong error message, inherited from Search 5. 15:28 < fax4ever> Fourthly, I added the generic type to the PropertyHadler mapper Pojo class, 15:28 < fax4ever> so that we would able to avoid some casts. 15:28 < fax4ever> Fiftly, I reviewed several pull requests. 15:28 < fax4ever> Finally, yesterday I started the issue to support the `indexNullAs` field parameter again. 15:28 < fax4ever> I'm talking about it in the next topic. 15:29 < fax4ever> I think we can move to it, thanks. 15:29 < gsmet> #topic Next 2 weeks Fabio 15:29 < fax4ever> Continuing on 'indexNullAs' parameter issue. 15:29 < fax4ever> I can tell you that the Elasticsearch part has been already done and 15:29 < fax4ever> you can find it in a preview pull request. 15:29 < fax4ever> Essentially, we have used the 'null_value' Elasticsearch field mapping option. 15:29 < fax4ever> With this implementation the DSL API method indexNullAs is type safe. 15:30 < fax4ever> It means that the indexNullAs method requires a value consistent with the type of the field. 15:30 < fax4ever> Then using this feature in the bridges is type safe. 15:30 < fax4ever> On the other hand, the annotation property requires a string, 15:30 < fax4ever> so I'm working on the conversion ( parsing? ) part, 15:30 < fax4ever> to reuse the method through the annotation interface. 15:30 < fax4ever> Furthermore, the list of the issues Yoann has left me it's still long :) 15:31 < fax4ever> As usual, I'll follow the precedence order defined in the current sprint. 15:31 < fax4ever> You can watch our progress going to the sprint page: HSEARCH - 2019-06. 15:31 < fax4ever> In a nutshell, they are about: 15:31 < fax4ever> (1) Strengthen some test on dates 15:31 < fax4ever> (2) Use the new Lucene 8 default normalizer 15:31 < fax4ever> (3) Make some changes on our mass indexer progress monitor 15:31 < fax4ever> (4) Allow annotations to be defined on default interface methods too 15:31 < fax4ever> (5) Restore some compatibility checks on analyzers 15:31 < fax4ever> (6) Make some classes thread safe 15:32 < fax4ever> (7) Support BigDecimal and BigInteger. 15:32 < fax4ever> The last would use some introspections from Hibernate ORM on field definition, 15:32 < fax4ever> such as @Column.lenght, to convert the BigDecimal into a long. 15:32 < gsmet> I don't think we need the full list of items of the next sprint 15:32 < fax4ever> Told that I think that's all from me. 15:32 < gsmet> OK 15:32 < gsmet> #topic Progress Koen 15:32 < fax4ever> Thank you for your attention. 15:33 < koentsje> i have released hibernate tools 5.4.2.Final 15:33 < koentsje> i have also integrated this new release into jboss tools 15:33 < koentsje> i did some testing and verification using java 12 and 13 15:33 < koentsje> on jboss tools hibernate that is 15:33 < koentsje> i have found no issues so far 15:34 < koentsje> (which doesn?t mean they don?t exist) 15:34 < koentsje> and then i worked on quarkus-eclipse, the eclipse plugins for quarkus 15:34 -!- sfikes [~sfikes at c-69-246-28-50.hsd1.ms.comcast.net] has joined #hibernate-dev 15:34 < koentsje> i have tried to make this ready for publication 15:35 < koentsje> making it ready from a legal point of view by adding license and copyright info 15:35 < koentsje> creating a readme, build and installation guides and a getting started guide 15:36 < koentsje> that?s it for the past sprint 15:36 < gsmet> #topic Next 2 weeks Koen 15:36 < koentsje> i need to setup continuous integration for quarkus-eclipse 15:37 < koentsje> finish the contribution guide which i started 15:37 < koentsje> and finally make the whole repository public 15:38 < gsmet> out of curiosity, what does it do? 15:38 < koentsje> further i want to create a quarkus-eclipse launch configuration to run and debug inside eclipse 15:38 < koentsje> i still need to develop the quarkus getting started cheat sheet (and maybe others) 15:39 < koentsje> gsmet, it helps users get started with quarkus 15:39 < gsmet> sure :) 15:39 < gsmet> but it allows to create a Quarkus project? 15:39 < gsmet> with the bom setup and everything? 15:40 < koentsje> i.e. create a project, install an extension, provide a view of available extensions 15:40 < gsmet> OK, cool 15:40 < koentsje> yes with bom etc 15:40 < koentsje> i desperately need to compile a wish list of functionality that would help users 15:41 < koentsje> so that?s one of the tasks 15:41 < gsmet> just send an email on quarkus-dev and see how it goes 15:41 < koentsje> finally i also want to continue some of the cleanup and restructuring work on the hibernate eclipse tooling that is still going on 15:42 < koentsje> gsmet, yes that?s the plan 15:42 < koentsje> that?s it for me 15:42 < gsmet> ok, thanks 15:42 < gsmet> #topic Progress Guillaume 15:42 < gsmet> not much from me 15:42 < gsmet> I worked a bit on HV but mostly worked on Quarkus 15:43 < gsmet> I'm making very slow progress on the Search extension being sidetracked by a lot of things 15:43 < gsmet> but I'm getting to it 15:43 < gsmet> I have an SSL related issue to fix and some cleanup to do on the ORM side (I made it work but it could use some cleanup) 15:43 < gsmet> hopefully, I'll be able to push it this week 15:44 < gsmet> #topic Next 2 weeks Guillaume 15:44 < gsmet> I need to spend some time on HV, we have a few PRs waiting for my attention 15:44 < gsmet> and pushing the Search Quarkus extension 15:45 < gsmet> I also would like to integrate HV and ORM on Quarkus as they are not integrated yet 15:45 < gsmet> that's pretty much it 15:45 < gsmet> #topic Progress Sanne 15:45 < gsmet> sannegrinovero: anything on your side? 15:46 < gsmet> apparently not :) 15:46 < koentsje> :D 15:46 < gsmet> let's close this meeting then, thanks everyone From sanne at hibernate.org Tue Apr 9 09:55:13 2019 From: sanne at hibernate.org (Sanne Grinovero) Date: Tue, 9 Apr 2019 14:55:13 +0100 Subject: [hibernate-dev] Make Gradle plugin available on plugins.gradle.org? (HHH-13354) In-Reply-To: References: Message-ID: Hi Gail, I'm familiar with the Gradle plugin portal, happy to look into this. Thanks for highlighting this one! I'll be off for travelling and conferences the next two weeks. If anyone needs this earlier, feel free to take the issue but le me know :) Thanks, Sanne On Tue, 9 Apr 2019 at 04:36, Gail Badner wrote: > > An issue was opened to make Gradle plugin available on plugins.gradle.org. > > Should this be done? If so, how? > > Regards, > Gail > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev From steve at hibernate.org Tue Apr 9 10:35:19 2019 From: steve at hibernate.org (Steve Ebersole) Date: Tue, 9 Apr 2019 09:35:19 -0500 Subject: [hibernate-dev] Make Gradle plugin available on plugins.gradle.org? (HHH-13354) In-Reply-To: References: Message-ID: It would need to be published differently than the rest of the modules (or an extra additional publish). It is a good idea though On Tue, Apr 9, 2019 at 9:15 AM Sanne Grinovero wrote: > Hi Gail, > > I'm familiar with the Gradle plugin portal, happy to look into this. > Thanks for highlighting this one! > > I'll be off for travelling and conferences the next two weeks. If > anyone needs this earlier, feel free to take the issue but le me know > :) > > Thanks, > Sanne > > > On Tue, 9 Apr 2019 at 04:36, Gail Badner wrote: > > > > An issue was opened to make Gradle plugin available on > plugins.gradle.org. > > > > Should this be done? If so, how? > > > > Regards, > > Gail > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev at lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > From gbadner at redhat.com Thu Apr 11 22:46:51 2019 From: gbadner at redhat.com (Gail Badner) Date: Thu, 11 Apr 2019 19:46:51 -0700 Subject: [hibernate-dev] HHH-13364 Message-ID: EntityManager#find and Query#getResultList / #getSingleResult do not behave consistently when failing to get a pessimistic lock with a timeout provided. I think EntityManager#find is working correctly, and I think Query#getResultList / #getSingleResult should be consistent with EntityManager#find. Could someone please take a look at HHH-13364 and let me know if I'm missing something? I've also created a pull request with tests and fix: https://github.com/hibernate/hibernate-orm/pull/2827 Thanks, Gail From andrea at hibernate.org Fri Apr 12 06:43:09 2019 From: andrea at hibernate.org (andrea boriero) Date: Fri, 12 Apr 2019 11:43:09 +0100 Subject: [hibernate-dev] HHH-13364 In-Reply-To: References: Message-ID: I gave a look at your PR and the change makes sense to me Andrea On Fri, 12 Apr 2019 at 03:54, Gail Badner wrote: > EntityManager#find and Query#getResultList / #getSingleResult do not behave > consistently when failing to get a pessimistic lock with a timeout > provided. > > I think EntityManager#find is working correctly, and I think > Query#getResultList / #getSingleResult should be consistent with > EntityManager#find. > > Could someone please take a look at HHH-13364 and let me know if I'm > missing something? > > I've also created a pull request with tests and fix: > https://github.com/hibernate/hibernate-orm/pull/2827 > > Thanks, > Gail > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > From gbadner at redhat.com Fri Apr 12 14:39:41 2019 From: gbadner at redhat.com (Gail Badner) Date: Fri, 12 Apr 2019 11:39:41 -0700 Subject: [hibernate-dev] HHH-13364 In-Reply-To: References: Message-ID: Thanks Andrea! On Fri, Apr 12, 2019 at 3:43 AM andrea boriero wrote: > I gave a look at your PR and the change makes sense to me > > Andrea > > On Fri, 12 Apr 2019 at 03:54, Gail Badner wrote: > >> EntityManager#find and Query#getResultList / #getSingleResult do not >> behave >> consistently when failing to get a pessimistic lock with a timeout >> provided. >> >> I think EntityManager#find is working correctly, and I think >> Query#getResultList / #getSingleResult should be consistent with >> EntityManager#find. >> >> Could someone please take a look at HHH-13364 and let me know if I'm >> missing something? >> >> I've also created a pull request with tests and fix: >> https://github.com/hibernate/hibernate-orm/pull/2827 >> >> Thanks, >> Gail >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > From rory.odonnell at oracle.com Fri Apr 19 08:21:31 2019 From: rory.odonnell at oracle.com (Rory O'Donnell) Date: Fri, 19 Apr 2019 13:21:31 +0100 Subject: [hibernate-dev] JDK 13 - Early Access build 17 is available Message-ID: <35f93e8b-d873-bbea-a9ba-f7d4430fdf9c@oracle.com> *Hi Sanne, * *OpenJDK builds *- JDK 13 - Early Access build 17 is available at http://jdk.java.net/13/ * These early-access , open-source builds are provided under the o GNU General Public License, version?2, with the Classpath Exception . * Changes in this build * Release notes [1] *Significant changes since the last availability email* * build 16 - Update the default enabled cipher suites preference (JDK-8163326 ) * build 16 - Add new keytool -showinfo -tls command for displaying TLS configuration information (JDK-8219861 ) * build 15? -*New Japanese Era Name **(JDK-8205432 )* * build 15? - Accessing REIWA era in java.time.chrono.JapaneseEra (JDK-8174268 ) * build 15? - Duplicated RSA services are no longer supported by SunJSSE provider (JDK-8220016 ) * build 15? - Use server cipher suites preference by default (JDK-8168261 ) * build 15? - The Swing Motif Look and Feel is deprecated and unsupported on macOS (JDK-8177960 ) * build 15? - Remove support for javadoc "frames" mode (JDK-8215599 ) Bug fix reported by Open Source Projects? : * build 15? - Unable to read certain PKCS12 keystores from SequenceInputStream (JDK-8157404) *April 2019 CPU Released* * As part of the Apr 2019 Critical Patch Update?we released OpenJDK 12.0.1? under the GNU General Public License, version?2, with the Classpath Exception . [2] * One change previously announced in the Java Cryptographic Roadmap [3] *Request for feedback *-? switch expressions in JDK 12? , feedback via amber-dev list [4] Rgds,Rory [1] http://jdk.java.net/13/release-notes [2] http://jdk.java.net/12 [3] https://java.com/en/jre-jdk-cryptoroadmap.html [4] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-April/002770.html -- Rgds, Rory O'Donnell Quality Engineering Manager Oracle EMEA, Dublin, Ireland From gbadner at redhat.com Mon Apr 22 17:27:16 2019 From: gbadner at redhat.com (Gail Badner) Date: Mon, 22 Apr 2019 14:27:16 -0700 Subject: [hibernate-dev] Hibernate ORM 5.3.10.Final released Message-ID: http://in.relation.to/2019/02/19/hibernate-orm-538-final-out/ From gbadner at redhat.com Mon Apr 22 17:30:33 2019 From: gbadner at redhat.com (Gail Badner) Date: Mon, 22 Apr 2019 14:30:33 -0700 Subject: [hibernate-dev] Hibernate ORM 5.3.10.Final released In-Reply-To: References: Message-ID: Sorry, I referenced the incorrect release announcement in my previous email. It should have been: http://in.relation.to/2019/04/22/hibernate-orm-5310-final-out/ On Mon, Apr 22, 2019 at 2:27 PM Gail Badner wrote: > http://in.relation.to/2019/02/19/hibernate-orm-538-final-out/ > From guillaume.smet at gmail.com Tue Apr 23 09:43:21 2019 From: guillaume.smet at gmail.com (Guillaume Smet) Date: Tue, 23 Apr 2019 15:43:21 +0200 Subject: [hibernate-dev] NoORM IRC meeting minutes Message-ID: Hi, Here are the minutes of this week's NoORM IRC meeting minutes. Once again, the bot wasn't there so it's all plain text all over again: ======================= 15:10 < gsmet> #topic Progress Fabio 15:10 < fax4ever> They have been a very intense two weeks. 15:10 < fax4ever> In my opinion the work on Hibernate Search 6 is going strong. 15:10 < fax4ever> Let's start saying that I've solved some minor issues. 15:10 < fax4ever> I did a little fix on our massive indexer, 15:11 < fax4ever> I made some tests on dates stronger 15:11 -!- yrodiere [~yrodiere at 2a01:e0a:85:4730:1dd8:d366:9f88:fa94] has joined #hibernate-dev 15:11 < fax4ever> and I added a test to check the mapping of annotations 15:11 < fax4ever> that are defined in default interface methods. 15:11 < fax4ever> Moreover, I completed the previous work on handling 15:11 < fax4ever> the 'minimumShouldMatch' default parameter mismatch, 15:12 < fax4ever> adding a missed test to check the out-of-bound 15:12 < fax4ever> of a given minimal-should-match. 15:12 < fax4ever> The bigger issue this time was the one to handle the 'indexNullAs' mapping option 15:12 < fax4ever> and provide a default value for a property of any type in case of null value. 15:12 < fax4ever> It had a consistent impact both on backends and mapping side. 15:12 < fax4ever> Since the mapping has the role here to convert, parse or validate 15:12 < fax4ever> annotation attribute strings in any supported backend field type values. 15:13 < fax4ever> Furthermore, another issue I did was the one to handle in a more consistent way 15:13 < fax4ever> what happens when we have a query on a text field 15:13 < fax4ever> insisting on multiple indexes and such indexes use different analyzers. 15:13 < fax4ever> Finally, I started to to test the full attribute validation 15:13 < fax4ever> of a given Elasticsearch schema. 15:13 < fax4ever> This is all for the progress topic, thanks. 15:14 < fax4ever> I think we can move on the next topic, please. 15:14 < gsmet> #topic Next 2 weeks Fabio 15:14 < fax4ever> Looking at the current sprint: `HSEARCH - 2019-07` board, 15:14 < fax4ever> anyone can find what is planned for the next two weeks. 15:14 < fax4ever> I'll provide you a brief summary here. 15:15 < fax4ever> Please take in account that I'll have two public holidays 15:15 < fax4ever> days in the last two weeks. 15:15 < fax4ever> I'm going to finish to provide a test for each attribute 15:15 < fax4ever> of any given Elasticsearch schema. 15:13 < fax4ever> This is all for the progress topic, thanks. 15:14 < fax4ever> I think we can move on the next topic, please. 15:14 < gsmet> #topic Next 2 weeks Fabio 15:14 < fax4ever> Looking at the current sprint: `HSEARCH - 2019-07` board, 15:14 < fax4ever> anyone can find what is planned for the next two weeks. 15:14 < fax4ever> I'll provide you a brief summary here. 15:15 < fax4ever> Please take in account that I'll have two public holidays 15:15 < fax4ever> days in the last two weeks. 15:15 < fax4ever> I'm going to finish to provide a test for each attribute 15:15 < fax4ever> of any given Elasticsearch schema. 15:15 < fax4ever> Then I'll try to use the built-in normalize Lucene method again. 15:15 < fax4ever> This time I'll use some insights provided by Yoann. 15:16 < fax4ever> After that I'll handle some other minor issues: 15:16 < fax4ever> thread safe fixes and ORM session synchronization. 15:16 < fax4ever> Finally, I would like to implement the support of BigDecimal and BigInteger. 15:16 < fax4ever> But I'm not sure I will be able to finish it in the next two weeks. 15:16 < fax4ever> That's all from me. Thanks 15:16 < gsmet> thanks 15:17 < gsmet> #topic Progress Koen 15:17 < koentsje> i have been working mostly on the quarkus tooling 15:17 < koentsje> i finished the contribution guide 15:18 < koentsje> and after adding all the legal stuff i finally made my private repository public 15:18 < koentsje> i have added another plugin for containing the cheat sheets and started working on the first one 15:19 < koentsje> that is supposed to be nothing else than the quarkus quickstart 15:19 < koentsje> i also did some minor maintenance work on both the hibernate eclipse tools and the core hibernate tools projects 15:19 < koentsje> updating dependencies etc 15:19 -!- rvansa [rvansa at nat/redhat/x-qrkdghwyrowutzhr] has joined #hibernate-dev 15:20 < koentsje> and i have started to investigate how to use the reddeer tools to setup some integration testing for the quarkus tools 15:20 < koentsje> that?s about what i did past 2 weeks 15:21 < gsmet> #topic Next 2 weeks Koen 15:21 < koentsje> i desperately want to setup continuous integration but i might want some help with that 15:22 < koentsje> futher i need to elaborate the create project wizard so that it becomes foolproof and that more options are possible 15:22 < koentsje> next i need to finish the first cheat sheet and possible add more 15:23 < koentsje> and i want to also create a reddeer test plugin to do the integration testing 15:23 < yrodiere> I can help with CI if you want to use Jenkins pipelines. Not sure it will be easy in your case though, given you may need Eclipse and all that. 15:23 < koentsje> yrodiere, that would be most certainly appreciated 15:24 < fax4ever> me too 15:24 < koentsje> further, i want to study gradle a little bit as i might switch the hibernate tools build from maven to gradle 15:24 < yrodiere> (just ping me when you want to talk about it) 15:25 < koentsje> and if there is still time there is some boring stuff to do in the hibernate eclipse tooling: adding license and copyright headers 15:25 < koentsje> that should be more than enough for the next two weeks 15:25 < gsmet> ok, thanks 15:25 < gsmet> #topic Progress Guillaume 15:25 < gsmet> I didn't do much on the Hibernate front 15:25 < koentsje> yrodiere, we might talk next friday during the hangout if you are present? 15:25 < yrodiere> koentsje: sure 15:26 < gsmet> I'm working on reviewing a Validator PR 15:26 < gsmet> I also reviewed a couple of Search PRs 15:27 < gsmet> oh, and I released ORM 5.3.10 (well, I pushed the button, Gail did the rest of the work) 15:27 < gsmet> #topic Next 2 weeks Guillaume 15:27 < gsmet> I will release Quarkus 0.14.0 tomorrow 15:27 < gsmet> I want to have the Search extension in 0.15.0 so I will have a 2 weeks window to merge it 15:28 < gsmet> I would like to have an alpha of the ongoing work by then 15:28 < gsmet> as there is a change in the configuration (version vs dialect) 15:28 < gsmet> yrodiere: is the next alpha planned for the end of this week? 15:28 < yrodiere> that should be doable, but I'd advice to first merge it, then open a second PR with this change 15:29 < yrodiere> Otherwise we'll always be waiting for one thing or another :) 15:29 < gsmet> yeah, whatever comes first 15:29 < gsmet> I'll create the PR as soon as I have everything working 15:29 < yrodiere> I wanted to do it the week after that, but I can do it earlier if necessary 15:29 < yrodiere> master is always ready for a release anyway :) 15:29 < gsmet> I just want to be sure I'll have the alpha with the version stuff before the "official" Quarkus release 15:30 < yrodiere> Which is when? 15:30 < gsmet> probably around May 8th 15:30 < gsmet> so it would work with your schedule 15:31 < gsmet> but I will be on vacation from May 3rd to May 9th 15:31 < gsmet> so I would need to get the PR ready by then and get it in 15:32 < gsmet> btw ^ PTO from May 3rd to May 9th 15:32 < yrodiere> ok 15:32 < gsmet> that's pretty much if for me 15:32 < gsmet> #topic Progress Yoann 15:32 < yrodiere> So, hi and sorry I joined late, I was reviewing a PR and forgot about the meeting 15:32 < yrodiere> Not much progress on my side since I only worked four days because of PTO and public holidays 15:33 < yrodiere> I reviewed a bunch of PRs 15:33 < yrodiere> Most of them were Fabio's, but one of them was from an external contributor, who fixed a minor problem in the Elasticsearch integration in 5.11 15:33 < yrodiere> Always nice to see external contributions 15:33 < yrodiere> I also had to work a bit on a java.time-related issue in ORM: https://github.com/hibernate/hibernate-orm/pull/2835 15:33 < jbossbot> git pull req [hibernate-orm] (open) Yoann Rodi?re HHH-13357 OffsetTimeTest fails using TimeAsTimestampRemappingH2Dialect in non-GMT European time zones https://github.com/hibernate/hibernate-orm/pull/2835 15:33 < jbossbot> jira [HHH-13357] OffsetTimeTest fails using TimeAsTimestampRemappingH2Dialect in non-GMT European time zones [Open (Unresolved) Bug, Major, hibernate-core, Yoann Rodi?re] https://hibernate.atlassian.net/browse/HHH-13357 15:33 < yrodiere> Apart from that, I added support for Elasticsearch 6.7 in Hibernate Search 15:33 < gsmet> you can't help it apparently :) 15:34 < yrodiere> the failing test was one I added, I kinda had to have a look :/ 15:34 < yrodiere> ES6.7 support required to make the dialect system in the Elasticsearch backend a bit more flexible, so that Quarkus users don't have to specify a new dialect when migrating from 6.6 to 6.7 just to avoid a few server-side warnings 15:34 < yrodiere> that's also what will require us to re-release for Quarkus 15:34 < yrodiere> That took a bit of time but I eventually got there 15:35 < yrodiere> I also started to work on a way for users to explicitly declare which properties they depend on in a given bridge: https://hibernate.atlassian.net/browse/HSEARCH-3297 15:35 < jbossbot> jira [HSEARCH-3297] Add an API to declare reindexing conditions in bridges [In Progress (Unresolved) New Feature, Major, mapper-pojo, Yoann Rodi?re] https://hibernate.atlassian.net/browse/HSEARCH-3297 15:35 < yrodiere> It will replace the accessor-based APIs, which was a bit weird and will now be considered experimental. 15:35 < yrodiere> It should make writing bridges easier, though a bit more dodgy too. We decided it was for the best in the F2F meeting. 15:35 < yrodiere> I'm not done yet, I'll finish this during the next two weeks 15:35 < yrodiere> That's mostly it for the past two weeks. 15:36 < gsmet> #topic Next 2 weeks Yoann 15:36 < yrodiere> I'll first finish that work on the explicit declaration of dependencies in bridges 15:36 < yrodiere> I also want to make support for ES 7 official, since they officially released ES7 15:36 < gsmet> I was going to say that :) 15:36 < yrodiere> This shouldn't be much work since I already got it working with Beta1 15:37 < yrodiere> apart from that... 15:37 < yrodiere> I have a bunch of tickets to expand on the current APIs 15:37 < yrodiere> like forcing users to declare which fields are multi-valued 15:38 < yrodiere> preparing the DSL for the introduction of query-wide extensions, such as what we'll have to do later for aggregations in Elasticsearch 15:38 < yrodiere> things like that 15:38 < yrodiere> and well, there's the release 15:38 < yrodiere> that's all from me 15:39 < gsmet> ok, thanks! 15:39 < gsmet> thanks everyone From guillaume.smet at gmail.com Thu Apr 25 13:14:15 2019 From: guillaume.smet at gmail.com (Guillaume Smet) Date: Thu, 25 Apr 2019 19:14:15 +0200 Subject: [hibernate-dev] [ORM] Do we have a way to check if an object is an entity? Message-ID: Hi, In Hibernate Validator, we have a TraversableResolver which avoids to validate the uninitialized properties of an entity. This is done in https://github.com/hibernate/hibernate-validator/blob/master/engine/src/main/java/org/hibernate/validator/internal/engine/resolver/JPATraversableResolver.java#L35 and, as you can see, we execute Persistence.getPersistenceUtil().isLoaded( traversableObject, traversableProperty.getName() ) even if the traversableObject has nothing to do with Hibernate ORM. I'm looking for an API that could tell me if an object is a class potentially managed by ORM (be it an entity, an embeddable or whatever: any class potentially containing a lazy field). I was thinking that maybe injecting an EntityManagerFactory (it would require CDI though) and using the Metamodel could somehow work... but the PersistenceUtil API we currently use is capable of dealing with several persistence providers and I don't think the injected EntityManagerFactory approach will fly in this case. Is there something I could use to do that, that would be portable and cover the cases currently (somehow) taken care of? Any ideas welcome. Thanks! -- Guillaume From steve at hibernate.org Thu Apr 25 14:05:42 2019 From: steve at hibernate.org (Steve Ebersole) Date: Thu, 25 Apr 2019 13:05:42 -0500 Subject: [hibernate-dev] [ORM] Do we have a way to check if an object is an entity? In-Reply-To: References: Message-ID: EMF + Metamodel are standard JPA contracts: ```` try { emf.getMetamodel().managedType( theClass ); } catch ( IllegalArgumentException e ) { // JPA defined exception if the passed class is not a managed type } ```` Again, that will (should) work on any provider On Thu, Apr 25, 2019 at 1:01 PM Guillaume Smet wrote: > Hi, > > In Hibernate Validator, we have a TraversableResolver which avoids to > validate the uninitialized properties of an entity. > > This is done in > > https://github.com/hibernate/hibernate-validator/blob/master/engine/src/main/java/org/hibernate/validator/internal/engine/resolver/JPATraversableResolver.java#L35 > and, as you can see, we execute Persistence.getPersistenceUtil().isLoaded( > traversableObject, traversableProperty.getName() ) even if the > traversableObject has nothing to do with Hibernate ORM. > > I'm looking for an API that could tell me if an object is a class > potentially managed by ORM (be it an entity, an embeddable or whatever: any > class potentially containing a lazy field). > > I was thinking that maybe injecting an EntityManagerFactory (it would > require CDI though) and using the Metamodel could somehow work... but the > PersistenceUtil API we currently use is capable of dealing with several > persistence providers and I don't think the injected EntityManagerFactory > approach will fly in this case. > > Is there something I could use to do that, that would be portable and cover > the cases currently (somehow) taken care of? > > Any ideas welcome. > > Thanks! > > -- > Guillaume > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > From guillaume.smet at gmail.com Thu Apr 25 14:24:39 2019 From: guillaume.smet at gmail.com (Guillaume Smet) Date: Thu, 25 Apr 2019 20:24:39 +0200 Subject: [hibernate-dev] [ORM] Do we have a way to check if an object is an entity? In-Reply-To: References: Message-ID: On Thu, Apr 25, 2019 at 8:05 PM Steve Ebersole wrote: > EMF + Metamodel are standard JPA contracts: > > ```` > try { > emf.getMetamodel().managedType( theClass ); > } > catch ( IllegalArgumentException e ) { > // JPA defined exception if the passed class is not a managed type > } > > Again, that will (should) work on any provider > Thanks. So I was pretty sure it would work with any provider. My question was more: how to make it work with multiple providers? Right now, the current implementation is very low level and doesn't use anything but JPA to get the EMF. But I didn't see any way to get all the potentially created EMF. I suppose I could try to get all the EMF from CDI - that would make this feature CDI-compatible only but I suppose it's acceptable. I will probably will need to do that after everything is initialized or I will have a chicken and egg problem as the EMF needs to get the ValidatorFactory. The thing is that, in this case, all the EMF should be created via CDI or it won't work very well. Collecting once and for all all the managed types via emf.getMetamodel().getManagedTypes() should work. @Gunnar Morling does it make sense to you too? -- Guillaume From steve at hibernate.org Thu Apr 25 14:42:39 2019 From: steve at hibernate.org (Steve Ebersole) Date: Thu, 25 Apr 2019 13:42:39 -0500 Subject: [hibernate-dev] [ORM] Do we have a way to check if an object is an entity? In-Reply-To: References: Message-ID: That's going to depend on which "bootstrap" they use. JPA defines 2 which it terms "SE" and "EE". Not sure this will work in all EE bootstrap environments, but you have: ```` PersistenceProviderResolver resolver = PersistenceProviderResolverHolder.getPersistenceProviderResolver(); List providers = resolver.getPersistenceProviders(); ```` On Thu, Apr 25, 2019 at 1:25 PM Guillaume Smet wrote: > On Thu, Apr 25, 2019 at 8:05 PM Steve Ebersole > wrote: > >> EMF + Metamodel are standard JPA contracts: >> >> ```` >> try { >> emf.getMetamodel().managedType( theClass ); >> } >> catch ( IllegalArgumentException e ) { >> // JPA defined exception if the passed class is not a managed type >> } >> >> Again, that will (should) work on any provider >> > > Thanks. > > So I was pretty sure it would work with any provider. My question was > more: how to make it work with multiple providers? Right now, the current > implementation is very low level and doesn't use anything but JPA to get > the EMF. But I didn't see any way to get all the potentially created EMF. > > I suppose I could try to get all the EMF from CDI - that would make this > feature CDI-compatible only but I suppose it's acceptable. I will probably > will need to do that after everything is initialized or I will have a > chicken and egg problem as the EMF needs to get the ValidatorFactory. The > thing is that, in this case, all the EMF should be created via CDI or it > won't work very well. > > Collecting once and for all all the managed types via > emf.getMetamodel().getManagedTypes() should work. > > @Gunnar Morling does it make sense to you too? > > -- > Guillaume > > > From yoann at hibernate.org Tue Apr 30 05:45:55 2019 From: yoann at hibernate.org (Yoann Rodiere) Date: Tue, 30 Apr 2019 11:45:55 +0200 Subject: [hibernate-dev] Jenkins upgrade Message-ID: Hello, TL;DR: I just updated Jenkins and its plugins. If things stop working correctly, please let me know. Some details below, in case I'm not here when things start to break down... I updated Jenkins and its plugins to the latest versions, hoping to fix the problem we've been having lately where we would only ever get a single EC2 slave. The result was an AWS EC2 plugin that started many, many EC2 slaves, but on the Jenkins side mapped all slaves to the same URL, which resulted in multiple builds running concurrently on the same EC2 instance, which obviously resulted in many failures. I rolled back the AWS EC2 plugin from 1.42 to 1.39 (like I had to do a few weeks ago), and things to be back to normal. It even works better than before I attempted the upgrade: the plugin correctly spawns multiple slaves as required. Frankly I don't understand what is going on, but it works again so I'll stop touching it. I suppose I should take the time to investigate, attempt to reproduce the problem and report it to the plugin maintainers. I currently do not have a few days to spare for that, so it'll wait... For the record, I also had to do the following during the upgrade: - I had to update the AWS permissions for the EC2 plugin: https://wiki.jenkins.io/display/JENKINS/Amazon+EC2+Plugin#AmazonEC2Plugin-Version1.41(Oct24th,2018) - I had to install a plugin to ensure running builds are no longer allowed to do whatever they want (~root permissions): https://jenkins.io/doc/book/system-administration/security/build-authorization/ Cheers, Yoann Rodi?re Hibernate NoORM Team yoann at hibernate.org From davide at hibernate.org Tue Apr 30 08:33:36 2019 From: davide at hibernate.org (Davide D'Alto) Date: Tue, 30 Apr 2019 14:33:36 +0200 Subject: [hibernate-dev] Jenkins upgrade In-Reply-To: References: Message-ID: On a related note, I've created a new AMI to use as slave and configure Jenkins to use it. If there are issues, it is still possible to use the old one by updating the Jenkins configuration (http://ci.hibernate.org/configure) to the AMI ID we used before (custom fedora v23). Cheers, Davide On Tue, Apr 30, 2019 at 11:46 AM Yoann Rodiere wrote: > > Hello, > > TL;DR: I just updated Jenkins and its plugins. If things stop working > correctly, please let me know. > > Some details below, in case I'm not here when things start to break down... > > I updated Jenkins and its plugins to the latest versions, hoping to fix the > problem we've been having lately where we would only ever get a single EC2 > slave. > > The result was an AWS EC2 plugin that started many, many EC2 slaves, but on > the Jenkins side mapped all slaves to the same URL, which resulted in > multiple builds running concurrently on the same EC2 instance, which > obviously resulted in many failures. > > I rolled back the AWS EC2 plugin from 1.42 to 1.39 (like I had to do a few > weeks ago), and things to be back to normal. It even works better than > before I attempted the upgrade: the plugin correctly spawns multiple slaves > as required. > > Frankly I don't understand what is going on, but it works again so I'll > stop touching it. I suppose I should take the time to investigate, attempt > to reproduce the problem and report it to the plugin maintainers. I > currently do not have a few days to spare for that, so it'll wait... > > For the record, I also had to do the following during the upgrade: > > - I had to update the AWS permissions for the EC2 plugin: > https://wiki.jenkins.io/display/JENKINS/Amazon+EC2+Plugin#AmazonEC2Plugin-Version1.41(Oct24th,2018) > - I had to install a plugin to ensure running builds are no longer > allowed to do whatever they want (~root permissions): > https://jenkins.io/doc/book/system-administration/security/build-authorization/ > > Cheers, > > > Yoann Rodi?re > Hibernate NoORM Team > yoann at hibernate.org > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev From steve at hibernate.org Tue Apr 30 09:11:18 2019 From: steve at hibernate.org (Steve Ebersole) Date: Tue, 30 Apr 2019 08:11:18 -0500 Subject: [hibernate-dev] Jenkins upgrade In-Reply-To: References: Message-ID: Thanks guys! On Tue, Apr 30, 2019 at 8:07 AM Davide D'Alto wrote: > On a related note, I've created a new AMI to use as slave and > configure Jenkins to use it. > If there are issues, it is still possible to use the old one by > updating the Jenkins configuration (http://ci.hibernate.org/configure) > to the AMI ID we used before (custom fedora v23). > > Cheers, > Davide > > On Tue, Apr 30, 2019 at 11:46 AM Yoann Rodiere > wrote: > > > > Hello, > > > > TL;DR: I just updated Jenkins and its plugins. If things stop working > > correctly, please let me know. > > > > Some details below, in case I'm not here when things start to break > down... > > > > I updated Jenkins and its plugins to the latest versions, hoping to fix > the > > problem we've been having lately where we would only ever get a single > EC2 > > slave. > > > > The result was an AWS EC2 plugin that started many, many EC2 slaves, but > on > > the Jenkins side mapped all slaves to the same URL, which resulted in > > multiple builds running concurrently on the same EC2 instance, which > > obviously resulted in many failures. > > > > I rolled back the AWS EC2 plugin from 1.42 to 1.39 (like I had to do a > few > > weeks ago), and things to be back to normal. It even works better than > > before I attempted the upgrade: the plugin correctly spawns multiple > slaves > > as required. > > > > Frankly I don't understand what is going on, but it works again so I'll > > stop touching it. I suppose I should take the time to investigate, > attempt > > to reproduce the problem and report it to the plugin maintainers. I > > currently do not have a few days to spare for that, so it'll wait... > > > > For the record, I also had to do the following during the upgrade: > > > > - I had to update the AWS permissions for the EC2 plugin: > > > https://wiki.jenkins.io/display/JENKINS/Amazon+EC2+Plugin#AmazonEC2Plugin-Version1.41(Oct24th,2018) > > - I had to install a plugin to ensure running builds are no longer > > allowed to do whatever they want (~root permissions): > > > https://jenkins.io/doc/book/system-administration/security/build-authorization/ > > > > Cheers, > > > > > > Yoann Rodi?re > > Hibernate NoORM Team > > yoann at hibernate.org > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev at lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev