[hibernate-dev] Any external uses for ORM's StatisticsImpl ?

[Yoann Rodiere]

Hi,

I had a quick look at Hibernate Search's source code, and couldn't find any
use of this class.
So +1 for me.


Yoann Rodière
Hibernate NoORM Team
yoann at hibernate.org


On Wed, 7 Aug 2019 at 11:08, Sanne Grinovero <sanne at hibernate.org> wrote:

> Hi all,
>
> while working on HHH-13527 I noticed that there's quite some
> complexity in StatisticsImpl to deal with the fact that the final
> field `sessionFactory` could be null in some cases.
>
> This field can only be null if its public no-argument constructor is
> invoked, yet there is no code in whole of ORM invoking this.
>
> I'm therefore tempted to remove this constructor and cleanup all those
> checks for null; anybody knows why that constructor was explicitly
> marked to stay with @SuppressWarnings({ "UnusedDeclaration" })  ?
>  -
> https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675fc8e9884c8f791e0/hibernate-core/src/main/java/org/hibernate/stat/internal/StatisticsImpl.java#L108-L111
>
> Suggesting this change for 5.4 (and beyond) only.
>
> Thanks,
> Sanne
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>