[hibernate-dev] [ORM] Converging on 5.4.2

[Gail Badner]

On Mon, Mar 4, 2019 at 2:31 AM Guillaume Smet <guillaume.smet at gmail.com>
wrote:

> Hi,
>
> I'm busy on other things these days but I would like to release a 5.4.2
> soon anyway as we already have fixed 28 issues, some of them quite
> annoying.
>
> Gail, I think most of the remaining open PRs need your attention.
>
> If you could take a look at them, that would be great. Let's maybe take a
> timebox of a few days and postpone to the next version whatever we are not
> confident enough to merge in this timebox.
>
> - https://github.com/hibernate/hibernate-orm/pull/2799 -> this one just
> has
> a checkstyle issue, it should be simple enough
>

I need to add more tests for this one.


> - https://github.com/hibernate/hibernate-orm/pull/2800 -> the date issue,
> Yoann pushed a new version, I think it should go in so that we can gather
> feedback before thinking about backporting it
>

+1; I'll review this in the next couple of days.


> - https://github.com/hibernate/hibernate-orm/pull/2801 -> don't know
> exactly the purpose or the state of this one but it looks like it should be
> addressed
>

+1;  I'll review this in the next couple of days.


> - https://github.com/hibernate/hibernate-orm/pull/2789 -> looks like it
> fixes a corner case but we would need to be sure it's safe
>

+1;  I'll review this in the next couple of days.


> - https://github.com/hibernate/hibernate-orm/pull/2753 -> this one I'm not
> sure at all
>

I'm not sure either; I'll take a look though.

>
> Thanks.
>
> --
> Guillaume
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>