[hibernate-dev] EntityMetamodel

[Steve Ebersole]

Seems like we dropped the need for the subclass checking here but did not
remove passing that Function.  Technically it could be removed and the
EntityMetamodel
constructor reverted

On Mon, Sep 2, 2019 at 9:14 PM Gail Badner <gbadner at redhat.com> wrote:

> HHH-11147 changed a EntityMetamodel constructor argument from
> a SessionFactoryImplementor to a PersisterCreationContext.
>
> Would a custom EntityPersister break due to calling the constructor with
> the new argument type?
>
> From what I can tell, the argument was changed to PersisterCreationContext
> go get access to an entity's metamodel, intended to be used
> by EnhancementHelper.includeInBaseFetchGroup.
>
> The Function<String,Boolean> subclassChecker is passed to:
> * BytecodeEnhancementMetadataPojoImpl.from
> * LazyAttributesMetadata.from
> * EnhancementHelper.includeInBaseFetchGroup
>
> EnhancementHelper.includeInBaseFetchGroup does not use the value passed in
> for hasSubclassChecker.
>
> Can the EntityMetamodel constructor be changed back to take a
> SessionFactoryImplementor?
>
> Can the hasSubclassChecker argument be removed from
> BytecodeEnhancementMetadataPojoImpl.from, LazyAttributesMetadata.from, and
> EnhancementHelper.includeInBaseFetchGroup?
>
> Thanks,
> Gail
>