[hibernate-issues] [Hibernate-JIRA] Created: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method

[Kenny MacLeod (JIRA)]

org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------

         Key: HHH-2021
         URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
     Project: Hibernate3
        Type: Bug

  Components: core  
    Versions: 3.1.3    
    Reporter: Kenny MacLeod
    Priority: Trivial


This one is no great shakes, but the first line of QueryKey.equals() casts the argument to QueryKey without checking for its type.  As such, the method is fragile.

It should be consistent with CacheKey, which does an instanceof check before the cast.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira