[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1470) Enhance Hibernate-Mapping DTD Definition of type element

[Michael Plöd (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1470?page=comments#action_24026 ] 

Michael Plöd commented on HHH-1470:
-----------------------------------

Max,
here is my patch. I would be really really good if you could apply this in a future release:

Index: /Users/mploed/Documents/Java/workspace/Hibernate3/src/org/hibernate/hibernate-mapping-3.0.dtd
===================================================================
--- /Users/mploed/Documents/Java/workspace/Hibernate3/src/org/hibernate/hibernate-mapping-3.0.dtd	(revision 10307)
+++ /Users/mploed/Documents/Java/workspace/Hibernate3/src/org/hibernate/hibernate-mapping-3.0.dtd	(working copy)
@@ -725,11 +725,11 @@
<!-- Declares the element type of a collection of basic type -->
-<!ELEMENT element (column|formula)*>
+<!ELEMENT element (column|formula|type)*>
	<!ATTLIST element column CDATA #IMPLIED>
	<!ATTLIST element node CDATA #IMPLIED>
	<!ATTLIST element formula CDATA #IMPLIED>
-	<!ATTLIST element type CDATA #REQUIRED>
+	<!ATTLIST element type CDATA #IMPLIED>
	<!ATTLIST element length CDATA #IMPLIED>
	<!ATTLIST element precision CDATA #IMPLIED>
	<!ATTLIST element scale CDATA #IMPLIED>


> Enhance Hibernate-Mapping DTD Definition of type element
> --------------------------------------------------------
>
>          Key: HHH-1470
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1470
>      Project: Hibernate3
>         Type: Improvement

>  Environment: Hibernate 3.1.x
>     Reporter: Michael Plöd
>     Priority: Trivial

>
>
> As discussed with Steve in http://forum.hibernate.org/viewtopic.php?t=955303
> Could you please update the DTD Definition of "Element" as follows:
> <!ELEMENT element (column|formula|type)*>
>    <!ATTLIST element column CDATA #IMPLIED>
>    <!ATTLIST element node CDATA #IMPLIED>
>    <!ATTLIST element formula CDATA #IMPLIED>
>    <!ATTLIST element type CDATA #IMPLIED>
>    <!ATTLIST element length CDATA #IMPLIED>
>    <!ATTLIST element precision CDATA #IMPLIED>
>    <!ATTLIST element scale CDATA #IMPLIED>
>    <!ATTLIST element not-null (true|false) "false">
>    <!ATTLIST element unique (true|false) "false"> 
> Actually type should be enabled as a child element of Element allowing users to add a parameter to a parameterized UserType inside an Element definition. Right now users will have to create a typedef with the parameter and place the name of the typedef in the attribute type. In addition to that the attribute definition of type must be set to IMPLIED.
> This would enalbe a mapping like that:
> <set name="ples" table="MY_PLES_TABLE">
>         <key column="myClassId"/>
>         <element>
>             <type name="my.comp.common.hibernate.PleType">
>                 <param name="type">my.comp.domain.PleElement</param>
>             </type>
>         </element>
> </set> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira