[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-734) Missing plugins, which are declared in feature.xml

[Michael Waldvogel (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-734?page=comments#action_24067 ] 

Michael Waldvogel commented on HBX-734:
---------------------------------------

Nice :) / Not alone with my splitting idea ;)

I personally patched the feature.xml and moved everything from GEF, EMF and WTP from plugin declarations to import declarations (except the real Hibernate plugins). My proposal would be, to split up Hibernate Tools into two features. One into the initial package (consisting of the seven Hibernate Tools plugins) and one, which contains all the plugins needed for Hibernate Tools.
If somebody does install WTP 1.5, then he also MUST install EMF and GEF because WTP 1.5 doesn't work without them (dependencies). People like us could just drop the second feature and the belonging plugins [that is easy; only patching feature.xml with any new version costs time]. Usual users wouldn't even realize, as both features are packaged in the same archive! :)

Further there is actually really one big drawback by including some WTP 1.5 binaries into the package : package versions differ little. That can cause a plugin to be loaded more than once, if they differ just in one little change ... :(

What do you think about that solution?
I just attach my feature.xml for Hibernate 3.2beta7 (I did not build another feature, because I don't need it ;) )

> Missing plugins, which are declared in feature.xml
> --------------------------------------------------
>
>          Key: HBX-734
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-734
>      Project: Hibernate Tools
>         Type: Bug

>     Versions: 3.2beta6
>  Environment: Windows XP SP2, Eclipse 3.2, WTP 1.5, Hibernate Tools 3.2beta6a
>     Reporter: Michael Waldvogel
>     Priority: Minor
>      Fix For: 3.2beta7

>
>
> In the feature.xml description for the Eclipse IDE there are two plugins, which are referenced but contained in the package. These are :
> org.eclipse.wst.common.frameworks.ui
> org.eclipse.wst.validation.ui
> I don't know if they are actually necessary for the package to work or not, but Eclipse Software Manager reports these missing plugins. As a workaround with installed WTP 1.5 I just removed the declarations and instead add requirements like :
> 	<import plugin="org.eclipse.wst.validation.ui" version="1.1.0" match="greaterOrEqual"/>
> 	<import plugin="org.eclipse.wst.common.frameworks.ui" version="1.1.0" match="greaterOrEqual"/>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira