[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

Michelle Baert (JIRA) noreply at atlassian.com
Sat Aug 26 02:57:24 EDT 2006


    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=comments#action_24116 ] 

Michelle Baert commented on HBX-737:
------------------------------------

Hi max, 

Before submitting that path, I carefully studied the class hierarchy of the concerned objects, looked for references and even in text search on all HibernateExt java sources.

I also tried the junit tests but many already failed in original version (I don't have clover.jar) ... I didn't debug that. 

... ;) I know all seem obvious at the time of writing, but then ... 
Never thought that commenting your code would help not only users (through api), contributors, but yourself too ?

 I'm now studiing hbm2x.GenericExporter, scanned for exporterClass usage, after the previous patch. 
None found except in the tests:
     HibernateExt\tools\src\test\org\hibernate\tool\hbm2x\GenericExporterTest.java

I'll submit another patch soon. 

Have a nice day,

Michelle

> hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass
> -------------------------------------------------------------------------------------
>
>          Key: HBX-737
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-737
>      Project: Hibernate Tools
>         Type: Bug

>   Components: ant
>     Versions: 3.2beta7
>  Environment: Hibernate 3.2 cr3, July 7, 2006
>     Reporter: Michelle Baert
>     Priority: Minor
>  Attachments: CustomExporter-20060825.zip
>
>
> I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask.
> There are 2 custom exporter classes: 
> - MyExplorer simply extends GenericExporter with nothing else
> - My VerboseExplorer is similar but provides log messages.
> When run with current version of hibernate-tools, it fails because filepattern has been lost.
> build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter
> When run after patching and jar rebuild, it runs fines.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira




More information about the hibernate-issues mailing list