[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[Michelle Baert (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=comments#action_24118 ] 

Michelle Baert commented on HBX-737:
------------------------------------

Here's the patch for 
HibernateExt/tools/src/java/org/hibernate/tool/hbm2x/GenericExporter.java
 
- suppressed exporterClass property, not used elsewhere in project
   (apart from HibernateExt\tools\src\test\org\hibernate\tool\hbm2x\GenericExporterTest.java)
 - suppressed start() method now useless. Superclass's method will be called instead.
 - added getter for filePattern, needed by custom subclasses.
 - added some javadoc: need to be clear for subclasses writers  

It assumes thats patch01.diff  has been applied.
I enclose also resulting files.

Michelle

> hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass
> -------------------------------------------------------------------------------------
>
>          Key: HBX-737
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-737
>      Project: Hibernate Tools
>         Type: Bug

>   Components: ant
>     Versions: 3.2beta7
>  Environment: Hibernate 3.2 cr3, July 7, 2006
>     Reporter: Michelle Baert
>     Priority: Minor
>  Attachments: CustomExporter-20060825.zip
>
>
> I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask.
> There are 2 custom exporter classes: 
> - MyExplorer simply extends GenericExporter with nothing else
> - My VerboseExplorer is similar but provides log messages.
> When run with current version of hibernate-tools, it fails because filepattern has been lost.
> build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter
> When run after patching and jar rebuild, it runs fines.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira