[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[Max Rydahl Andersen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=comments#action_24145 ] 

Max Rydahl Andersen commented on HBX-737:
-----------------------------------------

i finally realized what your "problem" is. 

the exception is thrown because neither the filepattern nor templateName is set on the genericexporter and currently that is *correct* behavior in my book ;)

there is a bug that the properties is actually not initalized to the values given from "above", but then there is still the issue of the two values actually being
set from the properties ...that is fixable.

I don't see a reason for pulling these parameters *up* in the exporter interface (at least not blindly) since they *only* makes sense for GenericExporter.

Anyhow the whole reason for this issue is that the property fields on exporters are not generally aligned with the properties and that should be fixed together
with defining a proper lifecycle for the Exporters.

> hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass
> -------------------------------------------------------------------------------------
>
>          Key: HBX-737
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-737
>      Project: Hibernate Tools
>         Type: Bug

>   Components: ant
>     Versions: 3.2beta7
>  Environment: Hibernate 3.2 cr3, July 7, 2006
>     Reporter: Michelle Baert
>     Priority: Minor
>  Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff
>
>
> I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask.
> There are 2 custom exporter classes: 
> - MyExplorer simply extends GenericExporter with nothing else
> - My VerboseExplorer is similar but provides log messages.
> When run with current version of hibernate-tools, it fails because filepattern has been lost.
> build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter
> When run after patching and jar rebuild, it runs fines.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira