[hibernate-issues] [Hibernate-JIRA] Updated: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[Michelle Baert (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ]

Michelle Baert updated HBX-737:
-------------------------------

    Attachment: Work03.diff

Here's my proposal patch.

The test runs fines.

IMHO, you can't tell it *only* makes sense for GenericExporter since you provide the feature of providing a custom exporter, and the required interface is Exporter. 
This exporter should implement a minimum interface being able to generate files, so it seems reasonable to me that the properties FilePattern and TemplateName are needed. The GenericExporter, as it is, seems very tied to POJO generation, which may not be needed for some user exporters.



> hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass
> -------------------------------------------------------------------------------------
>
>          Key: HBX-737
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-737
>      Project: Hibernate Tools
>         Type: Bug

>   Components: ant
>     Versions: 3.2beta7
>  Environment: Hibernate 3.2 cr3, July 7, 2006
>     Reporter: Michelle Baert
>     Priority: Minor
>  Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff
>
>
> I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask.
> There are 2 custom exporter classes: 
> - MyExplorer simply extends GenericExporter with nothing else
> - My VerboseExplorer is similar but provides log messages.
> When run with current version of hibernate-tools, it fails because filepattern has been lost.
> build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter
> When run after patching and jar rebuild, it runs fines.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira