[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2032) consider updating c3p0 because of connection leak bug

[Max Rydahl Andersen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2032?page=comments#action_24201 ] 

Max Rydahl Andersen commented on HHH-2032:
------------------------------------------

from c3p0:

It is backwards compatable, 100%. You should be able to just drop it in (as I did, using the bundled version of c3p0). Users should see no change in behavior, even with quite old versions of c3p0. Try it with 0.9.0. (There have been other ways to configure c3p0 besides PoolConfig for a long time -- I checked back to c3p0-0.8.5 and the requisite API is there. I think it goes back even further.)
 
The only very minor change users might see is that for parameters that users don't explicitly set in hibernate's config, the default values will be c3p0's defaults rather than those the old ConnectionProvider set. The old C3P0ConnectionProvider had hardcoded defaults:
 
  minPoolSize              ->   1
  maxPoolSize              ->   100
  acquireIncrement         ->   1
 
while c3p0's defaults for these parameters are:
 
  minPoolSize              ->   3
  maxPoolSize              ->   15
  acquireIncrement         ->   3
 
Hibernate's other defaults are identical to c3p0's.
 
The only change users will see is if they don't set the minimum or maximum size of the pool, or the acquire increment, the default value will be different. In practice, I think this will be quite harmless, as users usually do specify these parameters. Other than that, users should be able to use their existing configuration and libraries without problems.

> consider updating c3p0 because of connection leak bug
> -----------------------------------------------------
>
>          Key: HHH-2032
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2032
>      Project: Hibernate3
>         Type: Task

>   Components: core
>     Versions: 3.2.0.cr4
>     Reporter: Max Rydahl Andersen
>     Priority: Critical
>      Fix For: 3.2.0.ga
>  Attachments: C3P0ConnectionProvider.java
>
>
> c3p0-0.9.0.4 apparently has a connection leak (case  00010976) that is fixed in c3p0-0.9.1-pre6.
> will though have to look into if it is a drop-in replacement because of the following excerpt from the relaes notes:
> Deprecated PoolConfig, and began implementation of new C3P0Config approach to configuration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira