[hibernate-issues] [Hibernate-JIRA] Created: (HHH-2325) Exception handling in NullableType - NullPointerException

[Krzysztof Adamski (JIRA)]

Exception handling in NullableType - NullPointerException
---------------------------------------------------------

         Key: HHH-2325
         URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2325
     Project: Hibernate3
        Type: Bug

  Components: core  
    Versions: 3.1.2    
    Reporter: Krzysztof Adamski
 Assigned to: Steve Ebersole 
    Priority: Critical
     Fix For: 3.1.3, 3.2.0 cr1


I think the exception handling in nullabletype is broken/non-aligned.

in nullsafeset:

catch (RuntimeException re) {
			LogFactory.getLog( getClass() ).info(
					"could not bind value '" + toString(value) + 
					"' to parameter: " + index
				);
		}

notice that there are no throw re; here. meaning an exception can occur but the code will just continue.
AND RuntimeException is catched instead of Throwable meaning SQLException's which is the most likely exception will not result in a logging.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira