[hibernate-issues] [Hibernate-JIRA] Closed: (HHH-2251) Settings build unnecessary in schemaupdate/schemavalidate

[Max Rydahl Andersen (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2251?page=all ]
     
Max Rydahl Andersen closed HHH-2251:
------------------------------------

    Resolution: Fixed

fixed in head and 3.2.

Removed the buildSettings() completly and used the "old" way of looking up in properties.

> Settings build unnecessary in schemaupdate/schemavalidate
> ---------------------------------------------------------
>
>          Key: HHH-2251
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2251
>      Project: Hibernate3
>         Type: Bug

>     Versions: 3.2.1
>     Reporter: Max Rydahl Andersen
>     Priority: Critical
>      Fix For: 3.2.2

>
>
> the fix for HHH-2208 causes a new Settings object to be built for each table mapping when doing a schema update or validate. this is unnecessary. 
> in some scenarios, it might be expensive to build a new settings object because it communicates with the database for metadata and it also creates a cache provider, which might be expensive to create for clustered caches. 
> to fix, buildSettings (lines 947 and 1069) should be pulled out of the while loop.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira