[hibernate-issues] [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect

[Max Rydahl Andersen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=comments#action_24993 ] 

Max Rydahl Andersen commented on HB-1570:
-----------------------------------------

2.1.6 is *very* old.

why not submit a patch for Hibernate 3.2 if it is still relevant ?

> CLONE -dropIndex doesn't cound on Dialect
> -----------------------------------------
>
>          Key: HB-1570
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
>      Project: Hibernate2
>         Type: Bug

>   Components: core
>     Versions: 2.1.6
>  Environment: Hibernate 2.1.6, MySql 4.??
>     Reporter: Ohad Bruker

>
>
> In class net.sf.hibernate.mapping.Index method
> sqlDropString(Dialect dialect)
> doesn't count on dialect, and always makes name of index qualified:
> 		return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect), name);
> This will fail at least in case of MySql DB, because it doesn't understand {tablename}.{indexname} constructions, but {indexname} only.
> I propose next edition:
> 		return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify( table.getQualifiedName(dialect), name) : name);
> Is it suitable?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira