[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-754) hbm2hbmxml generates xml for subclasses that doesn't validate under the dtd

[Max Rydahl Andersen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-754?page=comments#action_24422 ] 

Max Rydahl Andersen commented on HBX-754:
-----------------------------------------

thanks. applied with some small changes to handle joined-subclass et.al. too.
Probably still not perfect, but better than before ;)

Good you added a testcase, but next time it would be great if you just added the corresponding
hbm.xml's since annotations is not available from hibernatetools test directly.

> hbm2hbmxml generates xml for subclasses that doesn't validate under the dtd
> ---------------------------------------------------------------------------
>
>          Key: HBX-754
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-754
>      Project: Hibernate Tools
>         Type: Patch

>   Components: ant
>     Versions: 3.2beta7
>     Reporter: Bruce Cota
>     Priority: Minor
>  Attachments: patch, test.tar
>
>
> When generating xml for subclasses, hbm2hbmxml makes the following errors:
> 1) A table attribute is always generated, but this is not a valid attribute for the subclass element
> 2) A discriminator-value attribute is always generated, but this is not a valid attribute for the 
> union-subclass element.
> 3) An Id element is generated, but this is not valid for any of the three different kinds of subclass
> elemtns.
> A test case  (test.jar) is attached demonstrating a subclass element  thatis generated with  a table attribute
> and an id element.
> A suggested patch is also attached.  It entails small changes to persistentclas.hbm.ftl  and three
> simple helper methods added to Cfg2HbmTool.java to support the persistentclass.hbm.ftl changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira