[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1739) HILO id can cause deadlock: Part deux

[Martin Slava (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1739?page=comments#action_24592 ] 

Martin Slava commented on HHH-1739:
-----------------------------------

Hi,
I have the same problem too. There is a problem with database connection closing in 
org.hibernate.engine.transaction.Isolater. In nested class method JdbcDelegate.delegateWork()
is issue in finally block. Code session.getBatcher().closeConnection( connection ); must be
out of the if statement block. This issue is fixed in version 3.2 RC4.

MS

> HILO id can cause deadlock: Part deux
> -------------------------------------
>
>          Key: HHH-1739
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1739
>      Project: Hibernate3
>         Type: Bug

>   Components: core
>     Versions: 3.1.3
>  Environment: Hibernate 3.1.3 running JDK 1.4.1_07 Solaris 5.8
> Adaptive Server Enterprise/12.5.2/EBF 12054 ESD#2/P/Sun_svr4/OS 5.8/ase1252/1844/64-bit/FBO/Thu Aug 12 10:51:11 2004
>     Reporter: Kirk Rasmussen

>
> Original Estimate: 1 minute
>         Remaining: 1 minute
>
> This is mostly a duplicate of HB-1246 but with a twist. I believe that there is a flaw in Hibernate's design for how it generates ids for some dialects. This is a particular problem for deep object graphs and/or at high volume. Or at least it is a problem for those of us stuck on the crappy Sybase platform.
> We have an application that creates hundreds of objects that need ids generated within a single transaction. It is quite common for us to potentially exhaust the connection pool with a deep object graph. We are persisting a Trade object which has a complex and deep object graph (upwards of 100s of persistent objects). Within each trade there are roughly 15 classes which need generated ids with 30 or more instances of each class in some cases. 
> IMO The design flaw is when the ids are generated. From quickly browsing the source it seems that they are being generated on the fly as the objects are being processed. This can result in running of out database connections when under load or when a particular trade has a large number of persistent object instances and deadlocking the system.
> A better design would be if the ids could be generated for all tables in a single transaction up front rather than issuing a whole bunch of individual transactions for each table and object. 
> I believe that TOPLink generates all its ids up front to avoid the described resource thrashing. It also has the configuration to generate ids from within the same transaction as the original unit of work or from a secondary unit of work.
> See org.hibernate.id.MultipleHiLoPerTableGenerator 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira