[hibernate-issues] [Hibernate-JIRA] Commented: (HSHARDS-8) ConcatenateListsExitStrategy has null shard when using SequentialShardAccessStrategy

[Max Ross (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_26742 ] 

Max Ross commented on HSHARDS-8:
--------------------------------

Yes, silly and wrong.

> ConcatenateListsExitStrategy has null shard when using SequentialShardAccessStrategy
> ------------------------------------------------------------------------------------
>
>                 Key: HSHARDS-8
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-8
>             Project: Hibernate Shards
>          Issue Type: Bug
>          Components: strategy
>    Affects Versions: 3.0.0.Beta1
>         Environment: Hibernate 3.2, Database: DB2
>            Reporter: Nathan Silberman
>            Assignee: Max Ross
>            Priority: Minor
>   Original Estimate: 1 minute
>  Remaining Estimate: 1 minute
>
> Line 40 of org.hibernate.shards.strategy.access.SequentialShardAccessStrategy reads:
>    if(exitStrategy.addResult(operation.execute(shard), null)) {
> when using 
>    if(exitStrategy.addResult(operation.execute(shard), shard )) {
> would avoid passing in a null shard to the exit strategy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira