[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2948) QueryStatistics.executionMinTime always = 0

[Michael Plöd (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_29154 ] 

Michael Plöd commented on HHH-2948:
-----------------------------------

I like the proposed solution. Another option would be to use a private boolean flag value which tells if the minTime has been set.

> QueryStatistics.executionMinTime always = 0 
> --------------------------------------------
>
>                 Key: HHH-2948
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2948
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.2.0.ga
>         Environment: database Oracle10g
>            Reporter: pi zhigang
>            Priority: Critical
>
> Becuase executionMinTime is initialized as zero (long default):
> --- org.hibernate.stat.QueryStatistics.java ----
> private long executionMinTime;
> and, the logic for assignment statement is:
> 	void executed(long rows, long time) {
> 		if (time < executionMinTime) executionMinTime = time;
>                ...
> I think the initial value for executionMinTime should be:
> private long executionMinTime = Long.MAX_VALUE;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira