[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[craig mcmillan (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_29196 ] 

craig mcmillan commented on HHH-2971:
-------------------------------------

i disagree

logs should be readable. imagine if every framework caught, logged and re-threw exceptions. logging would be a mess

i can of course filter out all logging from AbstractFlushingEventListener, but that sucks

what is the point of catching, logging and re-throwing the same exception ?

> AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HHH-2971
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.2.5
>         Environment: v3.2.5
>            Reporter: craig mcmillan
>            Assignee: Diego Pires Plentz
>            Priority: Minor
>         Attachments: tags.v325.r14204.patch
>
>
> AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira