[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-863) Hibernate Code Generation toolbar group is appearing in all Eclipse perspectives.

[John O'Shea (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-863?page=comments#action_25977 ] 

John O'Shea commented on HBX-863:
---------------------------------

Removing the hibernate menu was intentional as this hibernate action group fits naturally into the existing Run menu.

The "Invalid Menu Extension (Path is invalid) error is bogus alright, since it is valid to try contribute to "org.eclipse.ui.run/HibernateToolsGroup".  That said I have, on occasion seen this happen - seems to depend on the order in which the extensions initialize.  In the past I've gotten past this in the past by explicitly (re-)declaring the target menu id in the actionSet definition.  Try addding a <menu> element to the actionset:
e.g.

<extension
          point="org.eclipse.ui.actionSets">
       ...
   <actionSet 
            label="Hibernate Code Generation" 
            id="org.hibernate.eclipse.launch.actionset"> 
           <menu
                id="org.eclipse.ui.run"
                label="&amp;Run">
             <groupMarker name="HibernateToolsGroup"/>
          </menu>
          ...
          <action 
               label="Hibernate Code Generation..." 
               style="pulldown" 
               icon="icons/images/hibernate_launch.png" 
               class="org.hibernate.eclipse.launch.LaunchMenuDelegate" 
               menubarPath="org.eclipse.ui.run/HibernateToolsGroup" 
               id="org.hibernate.eclipse.launch.LaunchMenuDelegateMenu"> 
         </action> 
         ...
</extension>

> Hibernate Code Generation toolbar group is appearing in all Eclipse perspectives.
> ---------------------------------------------------------------------------------
>
>          Key: HBX-863
>          URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-863
>      Project: Hibernate Tools
>         Type: Bug

>   Components: eclipse
>     Versions: 3.2beta9
>  Environment: All
>     Reporter: John O'Shea
>  Attachments: Hibernate action group in run menu (Resource Perspective).jpg, Hibernate action group in run menu (Resource Perspective).jpg, hbx-863.patch, hib_tools.png, plugin.xml
>
>
> Currently the org.hibernate.eclipse.console plugin is contributing an action to the "org.eclipse.debug.ui.launchActionSet".  Consequently, the icon for the action group containing the "Hibernate Code Generation....." action is appearing in all Eclipse perspectives.  This is not really a good thing - it is polluting other perspectives that probably have no hibernate related functionality.  For example the attached screenshot shows the Synchronize perspective toolbar, with the Hibernate group visible - not very useful (and perhaps confusing for users).
> Could you perhaps move this action into a hibernate tools action set that is only displayed when the Hibernate Console (and maybe Java) perspective is active?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira