[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-67) Expose mergeFactor, maxMergeDocs and minMergeDocs

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_27495 ] 

Emmanuel Bernard commented on HSEARCH-67:
-----------------------------------------

Hi Hardy
The patch looks great. A fee comments:
 - I would like to get those values defined per DirectoryProvider (defaulted in 'default'), I think it makes more sense. From what I've seen the work should be minimal
 - try not to modify the style, it makes diffs harder to read
 - for some reason I cannot apply the patch, there seems to be a mix of CR / LR, and I can't apply it completely even after having used flip

How did you build the patch? try to use diff -u instead. (I remember having some issues with Eclipse when I used it).

> Expose mergeFactor, maxMergeDocs and minMergeDocs
> -------------------------------------------------
>
>                 Key: HSEARCH-67
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-67
>             Project: Hibernate Search
>          Issue Type: New Feature
>          Components: directory provider
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>             Fix For: 3.0.0.beta4
>
>         Attachments: HSEARCH-67-2.diff, HSEARCH-67.diff
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira