[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2301) Identity generator with custom insert SQL broken in 3.2

[Steve Ebersole (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_26884 ] 

Steve Ebersole commented on HHH-2301:
-------------------------------------

Well, I checked Gail's testcases.  Great work as usual Gail :)

I did make one minor change to your CustomSQLWithNativeGeneratedIdsTest class.  You had it extending from the HandSQLTest stuff.  I changed it to extend from the more generic DatabaseSpecificFunctionalTestCase.  I then applied this test to all dialects which support IDENTITY columns.  I then mapped just one entity (Organization) in the corresponding mapping, with a PK using the identity generator.  I also added your name as author on your work.

I also took this opporunity to clean up this series of tests a little bit.

> Identity generator with custom insert SQL broken in 3.2
> -------------------------------------------------------
>
>                 Key: HHH-2301
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2301
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.2.1
>         Environment: JDK 1.5.0_08, Windows XP
>            Reporter: Scott Rankin
>            Priority: Critical
>             Fix For: 3.2.4
>
>         Attachments: AbstractEntityPersister.patch, HHH-2301-new-testcase.patch, HHH-2301-testcase.patch
>
>
> When an entity is defined as having custom insert sql and has a ID generator strategy of "identity", the custom insert SQL is ignored in 3.2.  This previously worked in 3.1.3. 
> More details on the forum here: http://forum.hibernate.org/viewtopic.php?t=966317

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira