[hibernate-issues] [Hibernate-JIRA] Commented: (ANN-122) Add natural-id annotation

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/ANN-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_27011 ] 

Emmanuel Bernard commented on ANN-122:
--------------------------------------

Hi Nicolás,
the way the patch is done seems OK (I've just read the patch, not tried to apply it), just refrain from refactoring unrelated parts of the code (I've seen some import * and unrelated changes every now and then.

I am concerned about the property ordering though. Annotations are not guarantied to be processed int he order they are in the source code.
Which means a natural id with more than one property is not predictable with your proposed annotation

> Add natural-id annotation
> -------------------------
>
>                 Key: ANN-122
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-122
>             Project: Hibernate Annotations
>          Issue Type: New Feature
>          Components: binder
>    Affects Versions: 3.1beta6
>            Reporter: Mathias Bogaert
>            Priority: Minor
>             Fix For: 3.3.1
>
>         Attachments: natural-id-v2.patch, natural-id.patch
>
>
> HIbernate 3.0.5 introduced natural-id. Add this to Annotations, as a @NaturalId annotation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira