[hibernate-issues] [Hibernate-JIRA] Commented: (HB-1570) CLONE -dropIndex doesn't cound on Dialect

[Ohad Bruker (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HB-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_28769 ] 

Ohad Bruker commented on HB-1570:
---------------------------------

Also different for HSQL database:
drop index <index_name> on <table_name>;
Please don't close this bug, I will provide a patch in a few days.

> CLONE -dropIndex doesn't cound on Dialect
> -----------------------------------------
>
>                 Key: HB-1570
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HB-1570
>             Project: Hibernate2
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.1.6
>         Environment: Hibernate 2.1.6, MySql 4.??
>            Reporter: Ohad Bruker
>
> In class net.sf.hibernate.mapping.Index method
> sqlDropString(Dialect dialect)
> doesn't count on dialect, and always makes name of index qualified:
> 		return "drop index " + StringHelper.qualify( table.getQualifiedName(dialect), name);
> This will fail at least in case of MySql DB, because it doesn't understand {tablename}.{indexname} constructions, but {indexname} only.
> I propose next edition:
> 		return "drop index " + (dialect.qualifyIndexName() ? StringHelper.qualify( table.getQualifiedName(dialect), name) : name);
> Is it suitable?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira