[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-965) conditionally exclude catalog in H2MetaDataDialect

[Dan Allen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_28272 ] 

Dan Allen commented on HBX-965:
-------------------------------

However, I still question whether the H2 catalog should be declared at all. Declaring a catalog results in it being put in the entity classes and that ties the entity classes to H2. There are no catalogs in H2 (other than the default one), so it isn't really needed. Here is what is created:

@Entity
@Table(name = "ROLE", catalog = "H2",
  uniqueConstraints = @UniqueConstraint(columnNames = "NAME"))
public class Role implements java.io.Serializable {
}

> conditionally exclude catalog in H2MetaDataDialect
> --------------------------------------------------
>
>                 Key: HBX-965
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-965
>             Project: Hibernate Tools
>          Issue Type: Improvement
>          Components: reverse-engineer
>    Affects Versions: 3.2beta10
>         Environment: H2 1.0 (2007-06-17) and H2 1.0 (2007-07-12)
>            Reporter: Dan Allen
>            Priority: Minor
>         Attachments: HBX-965-v1.txt
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> Prior to build 55 (aka version 1.0 2007-07-12), the H2 database did not understand a query that included the catalog name. For instance, if you had a table called EMPLOYEE in the PUBLIC schema, H2.PUBLIC.EMPLOYEE would not work. After build 55, H2 understands this query.
> However, this brings up a different issue. You cannot create catalogs in H2, so really the H2 catalog is just a bogus place holder. That has to make you wonder if putting the catalog in the reverse engineering dialect is even wise. It makes the hbm2java generated classes very non-portable. This debate is a bit of a fuzzy area for me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira