[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1575) Issue HHH-708 not properly fixed

[Alex Goncharuk (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_28463 ] 

Alex Goncharuk commented on HHH-1575:
-------------------------------------


it takes two minutes to fix this issue. Please include it into the next release.  I confirm that I experienced the same problem and fixed it in the same way. 

now: 
			for ( int i=0; i<types.length; i++ ) {
				for ( int j=0; j<values.length; j++ ) {

should be:

			for ( int j=0; j<values.length; j++ ) {
				for ( int i=0; i<types.length; i++ ) {


please do it.


> Issue HHH-708 not properly fixed
> --------------------------------
>
>                 Key: HHH-1575
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1575
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: query-criteria
>    Affects Versions: 3.1.2
>         Environment: Oracle 9i, org.hibernate.criterion.InExpression
>            Reporter: Thierry Hermann
>
> The InExpression produces a statement like [where (key, station) in ((?,?),(?,?)...)] indeed.
> but the parameter binding is wrong.
> In fact if you look in org.hibernate.criterion.InExpression, getTypedValues() method (line: 53-54) both for loop should be inverted:
> for ( int i=0; i<types.length; i++ )  
>    for ( int j=0; j<values.length; j++ )
> should become:
> for ( int j=0; j<values.length; j++ )
>    for ( int i=0; i<types.length; i++ )  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira