[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1494) Path for Bug HHH-1493

[Patrick Decat (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_28238 ] 

Patrick Decat commented on HHH-1494:
------------------------------------

Here is a proper patch against current trunk at 14028 :

Index: /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java
===================================================================
--- /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java	(révision 14028)
+++ /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java	(copie de travail)
@@ -295,15 +295,14 @@
 				String defaultValue = column.getDefaultValue();
 				if ( defaultValue != null ) {
 					alter.append( " default " ).append( defaultValue );
-
-					if ( column.isNullable() ) {
-						alter.append( dialect.getNullColumnString() );
-					}
-					else {
-						alter.append( " not null" );
-					}
-
 				}
+				
+				if ( column.isNullable() ) {
+					alter.append( dialect.getNullColumnString() );
+				}
+				else {
+					alter.append( " not null" );
+				}
 
 				boolean useUniqueConstraint = column.isUnique() &&
 						dialect.supportsUnique() &&


> Path for Bug HHH-1493
> ---------------------
>
>                 Key: HHH-1494
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1494
>             Project: Hibernate3
>          Issue Type: Patch
>          Components: core
>    Affects Versions: 3.1.1, 3.1.2
>         Environment: sybase 11.1.1-swr8229, Windows XP, java 1.4.2_08-b03
>            Reporter: Alexis Midon
>         Attachments: Table.java.patch
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> This a patch for Bug HHH-1493: "mapping.Table fails to add a nullable column"
> http://opensource.atlassian.com/projects/hibernate/browse/HHH-1493

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira