[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-1072) hbm2java generates bad code for BigDecimal in equals() (Remains after HBX-426)

[Arnaud Renouf (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_30929 ] 

Arnaud Renouf commented on HBX-1072:
------------------------------------

I thought it was clear enough... sorry. The test was : "java.math.BigDecimal".equals(javaTypeName). I changed it to : "BigDecimal".equals(javaTypeName).
So in my implementation, the useCompareTo method is now :

private boolean useCompareTo(String javaTypeName) {
	// Fix for HBX-400
        //System.err.println("TYPE JAVA : " + javaTypeName);
	if ("BigDecimal".equals(javaTypeName)) {
		return true;
	} else {
		return false;
	}
}

> hbm2java generates bad code for BigDecimal in equals() (Remains after HBX-426)
> ------------------------------------------------------------------------------
>
>                 Key: HBX-1072
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1072
>             Project: Hibernate Tools
>          Issue Type: Bug
>          Components: hbm2java
>    Affects Versions: 3.2.1
>         Environment: Hibernate 3, Postgres
>            Reporter: Arnaud Renouf
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> Even with the correction in HBX-426, the bug is still there. In BasicPOJOClass.java in method useCompareTo(String javaTypeName), the javaTypeName is not the complete type name (with packages). So the test "java.math.BigDecimal".equals(javaTypeName) always returns false and the BigDecimal.compareTo method is never used in the generated equals method. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira