[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1936) IdentityGenerator doesn't support BigInteger as a valid identity type.

[Dejan Predovic (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_30935 ] 

Dejan Predovic commented on HHH-1936:
-------------------------------------

This issue is still open for both 3.2 and 3.3 branches.

We patched it by simply adding BigDecimal as an allowed type:

	public static Serializable get(ResultSet rs, Type type) throws SQLException, IdentifierGenerationException {
		Class clazz = type.getReturnedClass();
		if ( clazz == Long.class ) {
			return new Long( rs.getLong( 1 ) );
		}
		else if ( clazz == Integer.class ) {
			return new Integer( rs.getInt( 1 ) );
		}
		else if ( clazz == Short.class ) {
			return new Short( rs.getShort( 1 ) );
		}
		else if ( clazz == String.class ) {
			return rs.getString( 1 );
		}
		else if ( clazz == java.math.BigDecimal.class ) {
			return rs.getBigDecimal( 1 );
		}
		else {
			throw new IdentifierGenerationException( "this id generator generates long, integer, short, bigdecimal or string" );
		}

	}

and it works, we see no side effects. It would be nice if this could find it's way into the trunk.

> IdentityGenerator doesn't support BigInteger as a valid identity type.
> ----------------------------------------------------------------------
>
>                 Key: HHH-1936
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1936
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.0.5
>         Environment: Hibernate 3.0.5,  Sybase 12.05, Window/ Unix
>            Reporter: Leonid Shtivelman
>
> Identity generator strategy doesn't support BigInteger as a valid id type. This causes problem with Sybase which requires identity column to be numeric.  It would seem an obvious way to get around this problem is to set column mapping to long in hibernate xml and the actual java object.  This will solve obvious problem of creating identity, but will cause performance problem on selection.  In order for Sybase to use index for parameter query the variable type of the parameter and column index type has to be the same.  If ones maps column type to Long, Hibernate will use JDBC method setLong(long) to set value in the prepared statement.  This will cause mismatch between parameter type and column index type, and Sybase will not use index to locate index.   As you can see this is a big problem for anyone that is using identity columns Sybase and Hibernate

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira